[NoQA] Fix HR provider import in TimeSensitiveSection#92245
Conversation
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.91-0 🚀
Bundle Size Analysis (Sentry): |
Help site review: No changes requiredI reviewed the changes in this PR and no updates to the help site ( Why: This PR only updates an import path — Since no documentation changes are needed, I did not create a draft help site PR. @mhawryluk, let me know if you believe a user-facing behavior change is hiding here that I missed, and I'll re-review. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.94-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR only changes an import path — There is no user-facing behavior, UI, feature, or workflow change, so nothing under |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.94-0 🚀
|
Explanation of Change
Fixes typescript and eslint error on main. The imported function has been moved to a new file in a different PR.
Fixed Issues
$ #91712
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari