Skip to content

[Submit] Submit button with manager email prompt#87998

Merged
carlosmiceli merged 95 commits into
Expensify:mainfrom
hungvu193:feat-87264
Jun 19, 2026
Merged

[Submit] Submit button with manager email prompt#87998
carlosmiceli merged 95 commits into
Expensify:mainfrom
hungvu193:feat-87264

Conversation

@hungvu193

@hungvu193 hungvu193 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Add a new ReportSubmitTo Popover that will be shown when a member of submit workspace try to submit an expense.

Design doc section

Fixed Issues

$ #87264
PROPOSAL: N/A

Tests

Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisite: You're a member of a submit workspace.

Test 1: Expense view

  1. Go to submit workspace and submit an expense.
  2. Verify that a Popover appears and you're able to choose a manager to submit your expense to.
  3. Choose a manager and press confirm.
  4. Verify that you can submit your expense.
  5. Create another expense and click on it to see detail
  6. Try to submit expense from Submit header button
  7. Verify they you can choose a manager and submit expense.

Test 2: Search view

  1. Go to submit workspace
  2. Go to search (Spend) and try to submit that expense.
  3. Verify that a Popover appears and you're able to choose a manager to submit your expense to.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-05-27.at.17.19.12.mov
Android: mWeb Chrome
Screen.Recording.2026-05-27.at.17.22.55.mov
iOS: Native
Screen.Recording.2026-05-27.at.17.09.33.mov
iOS: mWeb Safari
Screen.Recording.2026-05-27.at.17.11.41.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-26.at.22.30.54.mov

@melvin-bot

melvin-bot Bot commented Apr 15, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@hungvu193

Copy link
Copy Markdown
Contributor Author

Note

Confirm to check if we also need to show popup with submit action on Search - submitMoneyRequestOnSearch

@iwiznia

iwiznia commented May 4, 2026

Copy link
Copy Markdown
Contributor

What's holding this up?

@hungvu193

Copy link
Copy Markdown
Contributor Author

Ideally we should hold it for oboarding PR since there is no way to create submit WS for now. I can resume the progress today.

@iwiznia

iwiznia commented May 5, 2026

Copy link
Copy Markdown
Contributor

since there is no way to create submit WS for now

You can create one from the oldDot pricing page

@hungvu193

Copy link
Copy Markdown
Contributor Author

I see. That's helpful 👍 currently I need to checkout onboarding existing PR to onboard on create one then switching back 😅

@hungvu193

Copy link
Copy Markdown
Contributor Author

@MelvinBot Assign yourself to this PR, merge main and revert the changes from Mobile-Expensify.

@MelvinBot MelvinBot self-assigned this May 5, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor

Done! I've:

  1. Assigned myself to this PR
  2. Merged main into feat-87264 — resolved merge conflicts in src/libs/actions/IOU/ReportWorkflow.ts (kept your manager email logic, integrated with main's getSubmitToAccountID)
  3. Reverted Mobile-Expensify submodule pointer back to main's version

@MelvinBot

Copy link
Copy Markdown
Contributor

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details

@hungvu193

Copy link
Copy Markdown
Contributor Author

Will work on this issue this weekend, currently focusing on Gate Submit feature PR.

@iwiznia

iwiznia commented May 18, 2026

Copy link
Copy Markdown
Contributor

@hungvu193 have you picked this back up?

@hungvu193

Copy link
Copy Markdown
Contributor Author

I'm on it now.

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
.../MoneyRequestReportView/SelectionToolbar/index.tsx 76.59% <ø> (ø)
...chList/ListItem/ExpenseReportListItemRow/index.tsx 0.00% <ø> (ø)
...earch/SearchList/ListItem/ReportListItemHeader.tsx 91.30% <100.00%> (+0.82%) ⬆️
.../TransactionListItem/TransactionListItemNarrow.tsx 0.00% <ø> (ø)
...em/TransactionListItem/TransactionListItemWide.tsx 0.00% <ø> (ø)
src/components/TransactionItemRow/index.tsx 83.33% <100.00%> (+0.25%) ⬆️
src/hooks/useSelectionModeReportActions.ts 86.36% <100.00%> (+0.48%) ⬆️
src/libs/PersonalDetailsUtils.ts 80.85% <100.00%> (+0.24%) ⬆️
src/pages/Search/SearchPage.tsx 85.71% <100.00%> (ø)
... and 16 more
... and 126 files with indirect coverage changes

@garrettmknight

Copy link
Copy Markdown
Contributor

BUG: if i choose the current user as the manager... the approve button doesn't show up

This is intentional so they're encouraged to actually submit the report to someone else to give us the opportunity to convert the company, not just the one submitter.

@abzokhattab

abzokhattab commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

hmmm but in a new workspace when i create an expense and submit, i see the current account present

is that expected?

Screen.Recording.2026-06-19.at.12.24.18.mov

@abzokhattab

Copy link
Copy Markdown
Contributor

@hungvu193 lgtm ... there are pending cleanup issues here #87998 (comment)

@iwiznia

iwiznia commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

If @hungvu193 can apply those cleanups before @carlosmiceli reviews, then fine, otherwise let's send that in a new PR so we can unblock other issues/PRs depending on this.

@carlosmiceli carlosmiceli merged commit ca3e2d5 into Expensify:main Jun 19, 2026
35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.17-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94254 was identified to be related to this PR.

@hungvu193

hungvu193 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Deploy Blocker #94254 was identified to be related to this PR.

I don't think so because I don't notice it during working on this PR. I think there was another PR was merged that might affect it.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #94281 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #94304 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94323 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #94347 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.