[Submit] Submit button with manager email prompt#87998
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
Note Confirm to check if we also need to show popup with submit action on Search - submitMoneyRequestOnSearch |
|
What's holding this up? |
|
Ideally we should hold it for oboarding PR since there is no way to create submit WS for now. I can resume the progress today. |
You can create one from the oldDot pricing page |
|
I see. That's helpful 👍 currently I need to checkout onboarding existing PR to onboard on create one then switching back 😅 |
|
@MelvinBot Assign yourself to this PR, merge main and revert the changes from Mobile-Expensify. |
|
Done! I've:
|
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
|
Will work on this issue this weekend, currently focusing on Gate Submit feature PR. |
|
@hungvu193 have you picked this back up? |
|
I'm on it now. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This is intentional so they're encouraged to actually submit the report to someone else to give us the opportunity to convert the company, not just the one submitter. |
|
hmmm but in a new workspace when i create an expense and submit, i see the current account present is that expected? Screen.Recording.2026-06-19.at.12.24.18.mov |
|
@hungvu193 lgtm ... there are pending cleanup issues here #87998 (comment) |
|
If @hungvu193 can apply those cleanups before @carlosmiceli reviews, then fine, otherwise let's send that in a new PR so we can unblock other issues/PRs depending on this. |
|
🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.17-0 🚀
Bundle Size Analysis (Sentry): |
|
Deploy Blocker #94254 was identified to be related to this PR. |
I don't think so because I don't notice it during working on this PR. I think there was another PR was merged that might affect it. |
|
Deploy Blocker #94281 was identified to be related to this PR. |
|
Deploy Blocker #94304 was identified to be related to this PR. |
|
Deploy Blocker #94323 was identified to be related to this PR. |
|
Deploy Blocker #94347 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
Explanation of Change
Add a new ReportSubmitTo Popover that will be shown when a member of submit workspace try to submit an expense.
Design doc section
Fixed Issues
$ #87264
PROPOSAL: N/A
Tests
Same as QA Steps
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisite: You're a member of a submit workspace.
Test 1: Expense view
Test 2: Search view
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-27.at.17.19.12.mov
Android: mWeb Chrome
Screen.Recording.2026-05-27.at.17.22.55.mov
iOS: Native
Screen.Recording.2026-05-27.at.17.09.33.mov
iOS: mWeb Safari
Screen.Recording.2026-05-27.at.17.11.41.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-26.at.22.30.54.mov