[CP Staging] Revert: Submit button with manager email prompt#94333
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@shubham1206agra @mountiny @carlosmiceli @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f343bf6d3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Failing test is not related. |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot assigned, try again |
|
Thanks My gate requires the requester to be the PR author, an assignee, or an existing co-author before I make code changes. So either:
Once one of those is in place, ping me again and I'll fix the ESLint failures (and check |
|
@MelvinBot try again |
…ch.ts and re-baseline seatbelt for reverted unsafe type assertions Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
|
Fixed the failing ESLint check and pushed to this branch ( The revert reintroduced older code that no longer matched current lint rules / the auto-tightened
Verified locally:
|
|
🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
@carlosmiceli looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Revert: Submit button with manager email prompt (cherry picked from commit a7895e2) (cherry-picked to staging by blimpich)
…050388663-1 🍒 Cherry pick PR #94333 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/carlosmiceli in version: 9.4.17-3 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed this PR against the help site articles under Why:
@carlosmiceli, since there is no help site PR to link (no docs changes were needed), there is nothing to mark |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/carlosmiceli in version: 9.4.18-0 🚀
Bundle Size Analysis (Sentry): This is being manually posted because the deploy failed to comment on all PRs. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀
|
Explanation of Change
Revert #87998
Related to #87264
Fixed Issues
$ #94254
$ #94323
$ #94304
$ #94281
PROPOSAL:N/A
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-23.at.23.09.40.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari