Expense-Scan and Manual Options Partially Hidden at Maximum Font Size by thelullabyy · Pull Request #75493 · Expensify/App

thelullabyy · 2025-11-19T03:58:18Z

Explanation of Change

Fixed Issues

$ #74676
PROPOSAL: #74676 (comment)

Tests

Pre-condition: Set app to XXX maximum font size

Launch app
Tap fab - create expense
Verity that "manual" and "scan" option is not partially hidden
Create a expense without category
Verify that in preview "draft", missing category error is not partially hidden
Open the expense
Verify that "Draft" tag on top; lower half of "you" in "waiting for you to fix expenses" message is not partially hidden.
Tap submit, approve
Verify that " outstanding" & "Approved" tag on top is not hidden partially

(All UI elements, error messages, and tags should be fully visible at maximum font size)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Pre-condition: Set app to XXX maximum font size

Launch app
Tap fab - create expense
Verity that "manual" and "scan" option is not partially hidden
Create a expense without category
Verify that in preview "draft", missing category error is not partially hidden
Open the expense
Verify that "Draft" tag on top; lower half of "you" in "waiting for you to fix expenses" message is not partially hidden.
Tap submit, approve
Verify that " outstanding" & "Approved" tag on top is not hidden partially

(All UI elements, error messages, and tags should be fully visible at maximum font size)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

codecov · 2025-11-19T04:09:33Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ents/HTMLEngineProvider/BaseHTMLEngineProvider.tsx	`88.46% <ø> (ø)`
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.72% <ø> (ø)`
...m/TransactionPreview/TransactionPreviewContent.tsx	`76.59% <100.00%> (ø)`
src/pages/home/report/ReportActionsList.tsx	`79.64% <ø> (-0.06%)`	⬇️
src/styles/index.ts	`45.65% <ø> (ø)`
src/styles/variables.ts	`100.00% <ø> (ø)`
... and 10 files with indirect coverage changes

…6/text-are-partially-hidden

melvin-bot · 2025-11-19T16:47:05Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

Good from a product perspective 👍

dubielzyk-expensify · 2025-11-20T00:04:35Z

This is looking great. Only issue is the gap above the composer:

QichenZhu · 2025-11-20T00:27:27Z

@thelullabyy, the lint error is not related, but there are some warnings we should fix.

QichenZhu · 2025-11-20T00:45:32Z

This is looking great. Only issue is the gap above the composer:

Good catch! I've noticed that for a while. If it's not worth a separate issue, we can fix it along the way. Let me know what works best.

dubielzyk-expensify · 2025-11-20T01:21:38Z

If you know the fix and can do it now, I'd be very grateful 😇

…6/text-are-partially-hidden

QichenZhu · 2025-11-25T01:03:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

QichenZhu · 2025-11-25T01:28:03Z

This is looking great. Only issue is the gap above the composer:

@thelullabyy thanks for working on it!

@dubielzyk-expensify do the screenshots below look good to you?

Expense	DM

Workspace	Workspace (archived)

dubielzyk-expensify · 2025-11-25T02:11:11Z

Looks good to me 👍

QichenZhu

Thank you!

grgia · 2025-11-26T12:26:28Z

+                                                styles.textMicroSupportingPadding,
+                                                styles.pre,
+                                                styles.flexShrink1,
+                                                {color: theme.danger},


NAB do we have a util for inline colors?

Yes, we do:

App/src/styles/utils/index.ts

Lines 1065 to 1070 in df111da

/**

* Returns color style

*/

function getColorStyle(color: string): TextColorStyle {

return {color};

}

Also there is styles.textDanger.

@thelullabyy

…6/text-are-partially-hidden

grgia · 2025-12-01T14:57:09Z

 import ConfirmModal from '@components/ConfirmModal';
 import {DelegateNoAccessContext} from '@components/DelegateNoAccessModalProvider';
 import Icon from '@components/Icon';
 import * as Expensicons from '@components/Icon/Expensicons';


@thelullabyy would you mind fixing this import lint warning in your PR?

Sure, I will fix it today

OSBotify · 2025-12-03T13:29:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-03T15:18:50Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.71-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

QichenZhu · 2025-12-04T00:36:27Z

@grgia @thelullabyy, this was reverted because of the spacing issue, but that is actually expected. Should we revert the revert?

OSBotify · 2025-12-04T15:44:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.71-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

thelullabyy · 2025-12-08T10:03:21Z

@QichenZhu @grgia I will revert the revert shortly. Please let me know if we have any other issues ^

thelullabyy · 2025-12-08T11:34:40Z

The revert PR is ready here

thelullabyy added 2 commits November 19, 2025 11:25

chore: remove height config

dcd2f09

chore: adjust padding

c0ef404

melvin-bot Bot assigned thelullabyy Nov 19, 2025

thelullabyy added 5 commits November 19, 2025 12:31

fix: red err message

361d9eb

fix: padding:

bd66c53

Merge branch 'main' of https://github.com/Expensify/App into fix/7467…

e014b51

…6/text-are-partially-hidden

rerun test

3843923

Merge branch 'main' of https://github.com/Expensify/App into fix/7467…

54a7bf2

…6/text-are-partially-hidden

thelullabyy marked this pull request as ready for review November 19, 2025 16:46

thelullabyy requested review from a team as code owners November 19, 2025 16:46

melvin-bot Bot requested a review from QichenZhu November 19, 2025 16:47

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 19, 2025 16:47

joekaufmanexpensify previously approved these changes Nov 19, 2025

View reviewed changes

thelullabyy added 2 commits November 24, 2025 20:15

Merge branch 'main' of https://github.com/Expensify/App into fix/7467…

83d1bb8

…6/text-are-partially-hidden

fix: gap

3c419bf

thelullabyy dismissed joekaufmanexpensify’s stale review via 3c419bf November 24, 2025 12:34

QichenZhu approved these changes Nov 25, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia November 25, 2025 11:53

grgia reviewed Nov 26, 2025

View reviewed changes

thelullabyy added 2 commits November 26, 2025 23:18

Merge branch 'main' of https://github.com/Expensify/App into fix/7467…

dd6b348

…6/text-are-partially-hidden

fix: styles

77ca8ab

QichenZhu approved these changes Nov 27, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia November 27, 2025 00:08

grgia reviewed Dec 1, 2025

View reviewed changes

grgia approved these changes Dec 3, 2025

View reviewed changes

grgia merged commit e6714bf into Expensify:main Dec 3, 2025
34 checks passed

OSBotify mentioned this pull request Dec 3, 2025

Deploy Checklist: New Expensify 2025-12-03 #76614

Closed

76 tasks

samranahm mentioned this pull request Dec 3, 2025

WS Chat - No vertical spacing between the last message and the composer #76644

Closed

8 tasks

mountiny mentioned this pull request Dec 3, 2025

[CP Staging] Revert "Expense-Scan and Manual Options Partially Hidden at Maximum Font Size" #76654

Merged

thelullabyy mentioned this pull request Dec 8, 2025

Expense-Scan and Manual Options Partially Hidden at Maximum Font Size #76976

Merged

54 tasks

QichenZhu mentioned this pull request Jan 2, 2026

[PAY NOW][$250] Expense-Scan and Manual Options Partially Hidden at Maximum Font Size #74676

Closed

8 tasks

	/**
	* Returns color style
	*/
	function getColorStyle(color: string): TextColorStyle {
	return {color};
	}

Uh oh!

Conversation

thelullabyy commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Nov 19, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Nov 19, 2025

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Nov 20, 2025

Uh oh!

QichenZhu commented Nov 20, 2025

Uh oh!

QichenZhu commented Nov 20, 2025

Uh oh!

dubielzyk-expensify commented Nov 20, 2025

Uh oh!

QichenZhu commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu commented Nov 25, 2025

Uh oh!

dubielzyk-expensify commented Nov 25, 2025

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

grgia Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

grgia Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

QichenZhu commented Dec 4, 2025

Uh oh!

OSBotify commented Dec 4, 2025

Uh oh!

thelullabyy commented Dec 8, 2025

Uh oh!

thelullabyy commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

thelullabyy commented Nov 19, 2025 •

edited

Loading

codecov Bot commented Nov 19, 2025 •

edited by github-actions Bot

Loading

QichenZhu commented Nov 25, 2025 •

edited

Loading