Quick cancel on edit message, re-opens edit text area - Reported by @kursat

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Send any message
3. Go back to the message and edit
4. Quickly hit Cancel

Expected Result:

User should see the edit window cancelled

Actual Result:

After hitting Cancel, window disappear for a sec and then popups back up

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.26-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

edit-message-quick-cancel.mp4

Expensify/Expensify Issue URL:
Issue reported by: @kursat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641398380101200

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kursat]

Proposal

We need to cancel debounce on deleteDraft like in publishDraft.

Please see:
https://github.com/kursat/App/commit/aabe17fa6934b0094f26e14f99c3d8ee145428ef

[roryabraham]

@kursat Your proposal looks good, thanks for reporting the bug and proposing the fix! I'm going to tag this as external, get an Upwork job created, and then you can apply on Upwork. Feel free to submit the PR as soon as you're ready.

Also, just a heads-up for the future, generally its a good idea for outside contributors such as yourself to wait until an issue has the Help Wanted label before leaving a proposal, because our contributing guidelines state that if you post a solution earlier than that it's fair game for us to use it without compensation.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[kursat]

Hey @roryabraham, Thanks for mentioning this. I'll be careful about it. I'll create the PR ASAP.

Also, just a heads-up for the future, generally its a good idea for outside contributors such as yourself to wait until an issue has the Help Wanted label before leaving a proposal, because our contributing guidelines state that if you post a solution earlier than that it's fair game for us to use it without compensation.

[roryabraham]

PR merged 🚀