Make Terms of Service and Privacy Policy accessible

[elemdos]

Details

See fixed issue

Fixed Issues

$ #5082

Tests

1. Open Settings screen
2. Click 'About'
3. Tab through About options
4. Verify footer links (Terms of Service, Privacy Policy) focus when tabbed

QA Steps

1. Open Settings screen
2. Click 'About'
3. Tab through About options
4. Verify footer links (Terms of Service, Privacy Policy) focus when tabbed

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Web.mov

Mobile Web

mobileweblinkopens.mov

Desktop

desktoplinks.mov

iOS

ios.mov

Android

androidscreen.mov

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[elemdos]

I have read the CLA Document and I hereby sign the CLA

[johnmlee101]

Can you quickly demonstrate that on any mobile device that there are no regressions in terms of the links working?

[elemdos]

@johnmlee101 sorry for the delay, still trying to get ios/android set up locally

[elemdos]

There was a styling issue on iOS

So I updated the TextLinkss to use styles.textMicroSupporting instead of chatItemMessageHeaderTimestamp (which was setting a static height on the link). Looks great now. This also solves the clipping (i.e. pipes) problem brought up in the issue. I've updated the demos accordingly.

Will have the Android & Mobile Web demos up tomorrow.

[johnmlee101]

Amazing! It all comes together 😄
Looking forward to the rest of the updated demos.

[elemdos]

@johnmlee101 sorry for the delay! Getting android set up was a doozy. Last demo added.

On that note, there's a visual regression now with the links on Android. Guessing it needs its own issue?

[kadiealexander]

Hi @MateoMorris, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

[johnmlee101]

Hello! This is no longer on hold. Anything left to do here other than merge with main?

[johnmlee101]

Friendly bump!

[elemdos]

@johnmlee101 sorry, been having some issues getting Android running locally. Just need that and this should be good to merge.

[elemdos]

@johnmlee101 okay ready to merge!

[johnmlee101]

Oh no! All commits need to be signed and your last commit wasn't. You might need to rebase locally and either force push this branch if possible or create a new PR and we can quickly move on that.

[elemdos]

@johnmlee101 not really sure I understand that, but I merged master back into this branch and it looks like that's Verified because it was done from Github. Is that what you're looking for?

[johnmlee101]

Let me see

[johnmlee101]

[johnmlee101]

You'll need all of your commits to have Verified next to it.
https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

[johnmlee101]

Let me know once that is done!

[elemdos]

Okay @johnmlee101 figured out code signing. How should I proceed?

[johnmlee101]

The best way to do this is to try a git rebase -f main (I think this works with forks?) and then force push to your branch with git push -f origin mateomorris:issue-5082

If the second part doesn't work, create a new PR, reference and close this one, and then we'll move it to there!

[elemdos]

Back at this after the holidays - should have it done today if everything goes smoothly 🤞