-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Internal QA]: feat: Unmask tooltip copy for Fullstory #55650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f51a3cf
e1210e5
89140f3
096b5af
4d31e35
b67fc97
8b8dee5
ef17bd1
bd3974b
3867af6
d8f8511
094864f
cd73ae3
2c1201f
eaaae34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ import TransparentOverlay from '@components/AutoCompleteSuggestions/AutoComplete | |
| import {PopoverContext} from '@components/PopoverProvider'; | ||
| import Text from '@components/Text'; | ||
| import useStyleUtils from '@hooks/useStyleUtils'; | ||
| import {parseFSAttributes} from '@libs/Fullstory'; | ||
| import CONST from '@src/CONST'; | ||
| import textRef from '@src/types/utils/textRef'; | ||
| import viewRef from '@src/types/utils/viewRef'; | ||
|
|
@@ -120,14 +121,32 @@ function BaseGenericTooltip({ | |
| return StyleUtils.getTooltipAnimatedStyles({tooltipContentWidth: contentMeasuredWidth, tooltipWrapperHeight: wrapperMeasuredHeight, currentSize: animation}); | ||
| }); | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jjcoffee do you have any idea if we have FS sessions for Native devices as well, if so then i need to update index.native.tsx as well, let me know
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure about this, maybe @puneetlath knows?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we do. |
||
| /** | ||
| * Extracts values from the non-scraped attribute WEB_PROP_ATTR at build time | ||
| * to ensure necessary properties are available for further processing. | ||
| * Reevaluates "fs-class" to dynamically apply styles or behavior based on | ||
| * updated attribute values. | ||
| */ | ||
| useLayoutEffect(parseFSAttributes, []); | ||
|
|
||
| let content; | ||
| if (renderTooltipContent) { | ||
| content = <View ref={viewRef(contentRef)}>{renderTooltipContent()}</View>; | ||
| content = ( | ||
| <View | ||
| ref={viewRef(contentRef)} | ||
| fsClass={CONST.FULL_STORY.UNMASK} | ||
| testID={CONST.FULL_STORY.UNMASK} | ||
| > | ||
| {renderTooltipContent()} | ||
| </View> | ||
| ); | ||
| } else { | ||
| content = ( | ||
| <Text | ||
| numberOfLines={numberOfLines} | ||
| style={textStyle} | ||
| fsClass={CONST.FULL_STORY.UNMASK} | ||
| testID={CONST.FULL_STORY.UNMASK} | ||
| > | ||
| <Text | ||
| style={textStyle} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we also need to set the
testID, see here, and this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thanks, will update