[$250] Unmask the search input field for Fullstory

[flaviadefaria]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.comCopy to clipboard to request to join our Slack channel!

Problem
We don't want any search input to be masked

Solution
Unmask the search input field

Upwork Automation - Do Not Edit
Issue Owner

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021881651594298704562
• Upwork Job ID: 1881651594298704562
• Last Price Increase: 2025-01-21
• Automatic offers:
• shubham1206agra | Reviewer | 105791262
• ishakakkad | Contributor | 105791264

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021881651594298704562

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[ishakakkad]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-21 11:01:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unmask the search input field for Fullstory

What is the root cause of that problem?

Feature request, we should add fsClass="fs-unmask" to unmask the input field.

What changes do you think we should make in order to solve the problem?

We need to add fsClass="fs-unmask" to the Search element here, like we did for the display names:

App/src/pages/home/HeaderView.tsx

Lines 230 to 231 in d50b5ae

	<View
	fsClass="fs-unmask"

We can add same way other places if needed.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Or we can add sClass="fs-unmask" here if we want to apply for all SearchRouterInput occurances.

[HenriqueCosta05]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Removing mask from input search field

What is the root cause of that problem?

From the View that wraps TextInput component, from SearchRouterInput, the fsClass was not explicitly defined so it still has a mask covering it.

What changes do you think we should make in order to solve the problem?

By adding a class fsClass="fs-unmask", from the selection below, it should not mask the input anymore.

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Line 91 in 42a656d

<View style={[outerWrapperStyle]}>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @HenriqueCosta05! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>