[Internal QA]: feat: Unmask tooltip copy for Fullstory by twilight2294 · Pull Request #55650 · Expensify/App

twilight2294 · 2025-01-23T12:28:56Z

Explanation of Change

Fixed Issues

$ #55425
PROPOSAL: #55425 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

jjcoffee · 2025-01-27T14:49:04Z

@twilight2294 Any update on this?

twilight2294 · 2025-01-27T16:18:48Z

Should we mark this no QA ? I don't think we can test this one, if so I can open this for review

jjcoffee · 2025-01-27T16:22:30Z

@twilight2294 I think you're right, based on this PR they had to do InternalQA to check the fullstory part.

melvin-bot · 2025-01-28T08:54:18Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2025-01-28T08:54:49Z

@@ -122,12 +122,20 @@ function BaseGenericTooltip({



@jjcoffee do you have any idea if we have FS sessions for Native devices as well, if so then i need to update index.native.tsx as well, let me know

I'm not sure about this, maybe @puneetlath knows?

Yes, we do.

jjcoffee · 2025-01-28T10:08:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

jjcoffee

LGTM overall, this needs internal testing though as the changes will only be visible in FS.

puneetlath

We need to update for native mobile as well.

twilight2294 · 2025-01-28T15:51:02Z

We need to update for native mobile as well.

thanks for the review @puneetlath , I updated the code accordingly

puneetlath

This doesn't seem to be working when I test it.

Also, can we use the CONST.FULL_STORY.UNMASK constant?

jjcoffee · 2025-01-29T08:55:05Z

@puneetlath I'm not too familiar with how we use FS, but based on this, it might need to be on staging before it can be tested?

puneetlath · 2025-01-29T18:24:49Z

I was testing locally, but it's possible I was doing something wrong. What about the constant. Shall we change that?

jjcoffee · 2025-01-30T08:31:27Z

Yes, I like that idea! Let's use the CONST.FULL_STORY.UNMASK constant @twilight2294

twilight2294 · 2025-01-30T09:14:12Z

-                    <View style={[styles.mh100, onboardingIsMediumOrLargerScreenWidth && StyleUtils.getWidthStyle(width), safeAreaPaddingBottomStyle]}>
+                    <View
+                        style={[styles.mh100, onboardingIsMediumOrLargerScreenWidth && StyleUtils.getWidthStyle(width), safeAreaPaddingBottomStyle]}
+                        fsClass="fs-unmask"


@jjcoffee @puneetlath if we use const then the above prop will be:

fsClass=`${CONST.FULL_STORY.UNMASK}`

This is what is expected right ? we would need to include `` because we are using a const, asking just to be sure

I think you just want to do fsClass={CONST.FULL_STORY.UNMASK}? Please also see this comment, I think we need to use parseFSAttributes in order for this to work.

you sure that it would assign fsClass an string value? because i think fsClass will only need string values

Please also see #55766 (comment), I think we need to use parseFSAttributes in order for this to work.

I'll take a look

you sure that it would assign fsClass an string value? because i think fsClass will only need string values

@twilight2294 I'm not sure what you mean here, can't you just test it and see if the class gets added? I don't see why it wouldn't, however!

Also bump on the parseFSAttributes question.

I updated, working on the failing unit tests, do you have any idea what might have caused it

I'm not sure but if I comment out useLayoutEffect(parseFSAttributes, []) only on ProductTrainingContext, the test no longer fails.

umm, testing what can be done here

@jjcoffee I got the fix, we didn't mock FullStory lib in the unit tests like we do here:

App/tests/perf-test/ReportActionsList.perf-test.tsx

Lines 29 to 33 in 631006e

jest.mock('@libs/Fullstory', () => ({

default: {

consentAndIdentify: jest.fn(),

},

getFSAttributes: jest.fn(),

So the tests were failing, I have updated it now 🥳

Apologies for the delay here, I will push the update now

jjcoffee · 2025-02-04T14:45:31Z

-                    <View style={[styles.mh100, onboardingIsMediumOrLargerScreenWidth && StyleUtils.getWidthStyle(width), safeAreaPaddingBottomStyle]}>
+                    <View
+                        style={[styles.mh100, onboardingIsMediumOrLargerScreenWidth && StyleUtils.getWidthStyle(width), safeAreaPaddingBottomStyle]}
+                        fsClass={CONST.FULL_STORY.UNMASK}


Looks like we also need to set the testID, see here, and this PR.

yes thanks, will update

puneetlath · 2025-02-06T17:45:00Z

Any update here?

twilight2294 · 2025-02-07T09:33:30Z

Any update here?

Working on fixing the failing test

twilight2294 · 2025-02-10T06:15:05Z

@jjcoffee @puneetlath all yours, apologies for the delay

jjcoffee

Thanks, LGTM!

puneetlath

Just a comment about comments. Otherwise looks good!

Also, you have conflicts.

puneetlath · 2025-02-11T16:22:54Z

        onConfirm?.();
    }, [onConfirm, closeModal]);

+    // Parse Fullstory attributes on initial render


Can we please update this comment to say "why", not just "what"?

puneetlath · 2025-02-11T16:23:06Z

    const StyleUtils = useStyleUtils();
    const {shouldUseNarrowLayout} = useResponsiveLayout();

+    // Parse Fullstory attributes on initial render


Can we please update this comment to say "why", not just "what"?

puneetlath · 2025-02-11T16:23:41Z

        };
    }, [tooltipName, registerTooltip, unregisterTooltip, shouldShow]);

+    // Parse Fullstory attributes on initial render


Same comment.

puneetlath · 2025-02-11T16:24:32Z

        });
    });

+    // Parse Fullstory attributes on initial render


Same comment.

puneetlath · 2025-02-11T16:24:49Z

        return StyleUtils.getTooltipAnimatedStyles({tooltipContentWidth: contentMeasuredWidth, tooltipWrapperHeight: wrapperMeasuredHeight, currentSize: animation});
    });

+    // Parse Fullstory attributes on initial render


Same comment.

OSBotify · 2025-02-12T15:10:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-12T22:26:41Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.98-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-17T09:04:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.98-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

unmask product training tooltips

f51a3cf

twilight2294 changed the title ~~unmask product training tooltips~~ feat: Unmask tooltip copy for Fullstory Jan 23, 2025

twilight2294 mentioned this pull request Jan 24, 2025

[HOLD for payment 2025-02-24][$250] Unmask tooltip copy for Fullstory #55425

Closed

Merge branch 'Expensify:main' into patch-22

e1210e5

twilight2294 changed the title ~~feat: Unmask tooltip copy for Fullstory~~ [Internal QA]: feat: Unmask tooltip copy for Fullstory Jan 28, 2025

twilight2294 added 3 commits January 28, 2025 14:22

unmask feature training modal

89140f3

unmask nudge migration modal

096b5af

unmask tooltip for web and desktop

4d31e35

twilight2294 marked this pull request as ready for review January 28, 2025 08:54

twilight2294 requested a review from a team as a code owner January 28, 2025 08:54

melvin-bot Bot requested review from jjcoffee and removed request for a team January 28, 2025 08:54

twilight2294 commented Jan 28, 2025

View reviewed changes

jjcoffee approved these changes Jan 28, 2025

View reviewed changes

melvin-bot Bot requested a review from puneetlath January 28, 2025 10:09

puneetlath reviewed Jan 28, 2025

View reviewed changes

unmask tooltips on native

b67fc97

puneetlath reviewed Jan 28, 2025

View reviewed changes

twilight2294 commented Jan 30, 2025

View reviewed changes

twilight2294 added 2 commits February 4, 2025 11:27

Merge branch 'Expensify:main' into patch-22

8b8dee5

update usage to CONST.FULL_STORY.UNMASK and use parseFSAttributes

ef17bd1

fix prettier

bd3974b

jjcoffee reviewed Feb 4, 2025

View reviewed changes

twilight2294 added 2 commits February 10, 2025 10:51

Merge branch 'Expensify:main' into patch-22

3867af6

fix failing tests and add testID

d8f8511

jjcoffee approved these changes Feb 10, 2025

View reviewed changes

melvin-bot Bot requested a review from puneetlath February 10, 2025 09:13

puneetlath requested changes Feb 11, 2025

View reviewed changes

twilight2294 added 2 commits February 12, 2025 07:03

update comment

094864f

Merge branch 'main' into patch-22

cd73ae3

twilight2294 commented Feb 12, 2025

View reviewed changes

Comment thread tests/navigation/ResizeScreenTests.tsx Outdated

Comment thread tests/navigation/ResizeScreenTests.tsx Outdated

twilight2294 added 2 commits February 12, 2025 12:46

Update tests/navigation/ResizeScreenTests.tsx

2c1201f

Update tests/navigation/ResizeScreenTests.tsx

eaaae34

puneetlath approved these changes Feb 12, 2025

View reviewed changes

puneetlath merged commit 82afd4e into Expensify:main Feb 12, 2025

github-actions Bot mentioned this pull request Feb 12, 2025

Deploy Checklist: New Expensify 2025-02-12 #56784

Closed

57 tasks

	jest.mock('@libs/Fullstory', () => ({
	default: {
	consentAndIdentify: jest.fn(),
	},
	getFSAttributes: jest.fn(),

Uh oh!

Conversation

twilight2294 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Jan 27, 2025

Uh oh!

twilight2294 commented Jan 27, 2025

Uh oh!

jjcoffee commented Jan 27, 2025

Uh oh!

melvin-bot Bot commented Jan 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

twilight2294 commented Jan 28, 2025

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Jan 29, 2025

Uh oh!

puneetlath commented Jan 29, 2025

Uh oh!

jjcoffee commented Jan 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

puneetlath commented Feb 6, 2025

Uh oh!

twilight2294 commented Feb 7, 2025

Uh oh!

twilight2294 commented Feb 10, 2025

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

twilight2294 commented Jan 23, 2025 •

edited

Loading

jjcoffee commented Jan 28, 2025 •

edited

Loading

jjcoffee left a comment •

edited

Loading