feat: fix the logic for generating optimistic personal details by allroundexperts · Pull Request #22401 · Expensify/App

allroundexperts · 2023-07-07T10:30:15Z

Details

This PR fixes the logic to create optimistic personal details object while splitting a bill.

Fixed Issues

$ #22104
PROPOSAL: #22104 (comment)

Tests

Split bill flow:

Open the App and login using any account.
Click on FAB icon and click on split bill
(IMP step)- Now search for a new user that has NO Expensify account and split the bill with the user
Verify that the user name appears in the owes report text since the beginning.

Request money flow

Open the App and login using any account.
Click on FAB icon and click on request money
Now search for a new user that has NO Expensify account and request money from the user
Verify that the user name appears in the owes text.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as test steps.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-07.at.11.28.46.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-07.at.3.15.00.PM.mov

Mobile Web - Safari

Screen.Recording.2023-07-07.at.3.12.14.PM.mov

Desktop

Screen.Recording.2023-07-07.at.2.59.26.PM.mov

iOS

Screen.Recording.2023-07-07.at.3.19.52.PM.mov

Android

Screen.Recording.2023-07-07.at.3.19.05.PM.mov

melvin-bot · 2023-07-07T10:30:20Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-07-10T07:10:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

8mb.video-Hiv-3G3anNuR.mp4

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

allroundexperts · 2023-07-10T07:54:46Z

@narefyev91 I think you need to approve the PR as well. Only then the internal team member will be assigned.

Beamanator

Overall code is looking good, but maybe we could use a bit more comments - especially in the createSplitsAndOnyxData changes

Beamanator · 2023-07-10T11:05:03Z

+        } else {
+            const existingChatReport = ReportUtils.getChatByParticipants([accountID]);
+            isNewOneOnOneChatReport = !existingChatReport;
+            createOptimisticPersonalDetails = isNewOneOnOneChatReport;


Can we rename this shouldCreateOptimisticPersonalDetails since this is a bool?

Beamanator · 2023-07-10T11:06:09Z

Also @allroundexperts I think you need to add tests for the requestMoney flow since that flow is affected by these changes

allroundexperts · 2023-07-10T14:50:53Z

@Beamanator Added test case for the change. I couldn't add much comments as I was unsure which exact part is unclear to you. Do you have suggestions?

Beamanator

Please undo the podfile change since i don't believe you need it here :D

And thanks for adding an automated test! I was actually meaning a manual test for QA as well :D

allroundexperts · 2023-07-11T10:28:36Z

@Beamanator Removed podfile changes and added test steps for request money flow as well.

Beamanator

Thanks @allroundexperts !

OSBotify · 2023-07-11T11:12:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-13T02:00:48Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-14T14:45:44Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh · 2023-10-24T16:38:50Z

+        } else {
+            const existingChatReport = ReportUtils.getChatByParticipants([accountID]);
+            isNewOneOnOneChatReport = !existingChatReport;
+            shouldCreateOptimisticPersonalDetails = isNewOneOnOneChatReport;


Great work to improve the previous logic here 👍 . But we need to also check if the personal details exist before optimistic creates a new one here. Otherwise, it will cause this issue #29024

feat: fix the logic for generating optimistic personal details

7acd667

allroundexperts requested a review from a team as a code owner July 7, 2023 10:30

melvin-bot Bot requested review from narefyev91 and removed request for a team July 7, 2023 10:30

narefyev91 reviewed Jul 10, 2023

View reviewed changes

narefyev91 approved these changes Jul 10, 2023

View reviewed changes

melvin-bot Bot requested a review from Beamanator July 10, 2023 07:55

Beamanator reviewed Jul 10, 2023

View reviewed changes

feat: add unit tests

f290485

feat: fix lint errors

92b9221

Beamanator requested changes Jul 11, 2023

View reviewed changes

Comment thread ios/Podfile.lock Outdated

fix: revert podfile changes

a4ad0b4

allroundexperts requested a review from Beamanator July 11, 2023 10:28

Beamanator approved these changes Jul 11, 2023

View reviewed changes

Beamanator merged commit e5b7e3a into Expensify:main Jul 11, 2023

OSBotify mentioned this pull request Jul 13, 2023

Deploy Checklist: New Expensify 2023-07-13 #22783

Closed

53 tasks

Beamanator mentioned this pull request Jul 13, 2023

[HOLD for payment 2023-07-21] [$1000] Web - Split bill with a new user displays 'undefined owes' on staging #22104

Closed

6 tasks

hoangzinh reviewed Oct 24, 2023

View reviewed changes

hoangzinh mentioned this pull request Oct 24, 2023

[HOLD for payment 2023-10-24] [$500] Email not found in new workspace after adding as member, splitting bill, deleting old workspace. #29024

Closed

6 tasks

Uh oh!

Conversation

allroundexperts commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 7, 2023

Uh oh!

narefyev91 commented Jul 10, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 left a comment

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented Jul 10, 2023

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator Jul 10, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts Jul 10, 2023

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Jul 10, 2023

Uh oh!

allroundexperts commented Jul 10, 2023

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

allroundexperts commented Jul 11, 2023

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 11, 2023

Uh oh!

OSBotify commented Jul 13, 2023

Uh oh!

OSBotify commented Jul 14, 2023

Uh oh!

hoangzinh Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

allroundexperts commented Jul 7, 2023 •

edited

Loading