[HOLD for payment 2023-10-24] [$500] Email not found in new workspace after adding as member, splitting bill, deleting old workspace.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create new account > Settings > Create workspace > Members > Add members (copy email for step 4)
2. Go to Announcement > Plus sign > Split bill > Add numbers > Split bill
3. Go to Workspace > Three dots > Delete workspace
4. Go back to Settings > Create workspace > Members > Add members > Paste copied email into workspace

Expected Result:

Email should be found when searching for it in the newly created workspace.

Actual Result:

Email cannot be found when searching for it in the newly created workspace.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-9
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recorder_06102023_123639.mp4

Screen.Recording.2023-10-06.at.2.31.20.AM.mov

Screen.Recording.2023-10-06.at.1.55.22.AM.mov

Screen.Recording.2023-10-06.at.1.52.45.AM.mov

Screen.Recording.2023-10-06.at.1.49.01.AM.mov

Screen.Recording.2023-10-06.at.1.43.45.AM.mov

Recording.11.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696584062077569

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01045d4102dd433123
• Upwork Job ID: 1710349407654047744
• Last Price Increase: 2023-10-06
• Automatic offers:
• hoangzinh | Reviewer | 27135873
• c3024 | Contributor | 27135874
• tewodrosGirmaA | Reporter | 27135875

Issue Owner

Current Issue Owner: @peterdbarkerUK

Issue Owner

Current Issue Owner: @peterdbarkerUK

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cannot invite a member X to a workspace B if X was added to a workspace A, then split a bill with X and then the workspace A is deleted.

What is the root cause of that problem?

When we create a split request this here

App/src/libs/actions/IOU.js

Lines 1060 to 1065 in a6d2f3e

	} else {
	const existingChatReport = ReportUtils.getChatByParticipants([accountID]);
	isNewOneOnOneChatReport = !existingChatReport;
	shouldCreateOptimisticPersonalDetails = isNewOneOnOneChatReport;
	oneOnOneChatReport = existingChatReport || ReportUtils.buildOptimisticChatReport([accountID]);
	}

checks if there is one to one chat report and if does not exists it sets shouldCreateOptimisticPersonalDetails to true even though a personal detail exists and this here

App/src/libs/actions/IOU.js

Line 1122 in 5dc3c25

isOptimisticPersonalDetail: true,

sets isOptimisticPersonalDetail to true and subsequently through buildOnyxDataForMoneyRequest, the personal detail is set with field isOptimisticPersonalDetail to true.
This here

App/src/libs/OptionsListUtils.js

Line 1262 in 5dc3c25

personalDetails: _.filter(personalDetailsOptions, (personalDetailsOption) => !personalDetailsOption.isOptimisticPersonalDetail),

does not show this optimistic personal detail and also no option is created because it already exists in personal details.

What changes do you think we should make in order to solve the problem?

We need to check if the accountID already exists in the personal details and if it does we should not change shouldCreateOptimisticPersonalDetails to true.
So we can subscribe to personal details in IOU and add this

const personalDetailExists = _.has(allPersonalDetails, accountID)

here

App/src/libs/actions/IOU.js

Line 1051 in 5dc3c25

and change these

App/src/libs/actions/IOU.js

Line 1059 in 5dc3c25

shouldCreateOptimisticPersonalDetails = !existingSplitChatReport;

App/src/libs/actions/IOU.js

Line 1063 in 5dc3c25

shouldCreateOptimisticPersonalDetails = isNewOneOnOneChatReport;

to

shouldCreateOptimisticPersonalDetails = !existingSplitChatReport && !personalDetailExists;

shouldCreateOptimisticPersonalDetails = isNewOneOnOneChatReport && !personalDetailExists;

What alternative solutions did you explore? (Optional)

We might consider changing the logic here

App/src/libs/actions/IOU.js

Line 1061 in 5dc3c25

const existingChatReport = ReportUtils.getChatByParticipants([accountID]);

to include the accountID of current user when we get report by participants
or
have a function to check if there is a chat with this participant instead of checking if a report has all participants like the existing getChatbyParticipants

Result

showInviteMember.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01045d4102dd433123

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

@hoangzinh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

Reviewing proposal. Btw @m-natarajan could you help to add "Bug" label to this issue in order to have a BZ member assigned to this issue? Thanks

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.