[HOLD for payment 2023-07-21] [$1000] Web - Split bill with a new user displays 'undefined owes' on staging

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome and login with User A
2. Click on FAB icon and click on split bill
3. (IMP step)- Now search for a new user that has NO Expensify account and split the bill with the user
4. Notice that for a small period of time it displays 'undefined' owes on the report
5. Follow the same steps on production , no such problem occurs

Expected Result:

Split bill with a new user should not display 'undefined'

Actual Result:

Split bill with a new user displays 'undefined owes'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-07-03_14.22.25.mp4

Recording.3376.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688373739740659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0162160db7d748962b
• Upwork Job ID: 1676900194451750912
• Last Price Increase: 2023-07-06

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill with new user displays undefined for user name when offline.

What is the root cause of that problem?

The root cause of this issue is that after migration from emails to account ids, we are not optimistically creating the user entry in the personalDetailsList object. Because of the missing entry, this condition returns undefined.

What changes do you think we should make in order to solve the problem?

We should create an entry in the personalDetailsList object optimistically here or here.
Note: We can also add the optimistic object somewhere else in our flow. The above 2 points are just an example of where we can add it.

What alternative solutions did you explore? (Optional)

If we do not want to create an optimistic persona detail object, we can also update the getPersonalDetailsForAccountID function such that it searches for the account id in the IOU object.

[madmax330]

Discussed here: https://expensify.slack.com/archives/C03TQ48KC/p1688391023413499?thread_ts=1688389934.788359&cid=C03TQ48KC

Since it is also happening in prod it's not a blocker.

[Julesssss]

Thanks, removed it from the checklist 👍