[NewContactPage] fix: same number added twice by Prince-Mendiratta · Pull Request #18536 · Expensify/App

Prince-Mendiratta · 2023-05-07T11:19:57Z

Details

With this PR, we are fixing the issue where the same contact number is accepted twice as a contact method on the NewContactMethod Page.

Fixed Issues

$ #18207
PROPOSAL: #18207 (comment)

Tests

Login to ND.
Go to Settings > Profile > Contact Method > New contact method.
Enter a number in international format, as per your country.
Copy that number and click on the Add button.
You'll be redirected to the Contact methods page. Wait for the number to be shown there properly with full opacity.
Click on New contact method.
Paste the same number again.
Click on the Add button.
Ensure that the same number does is not shown as a duplicate entry.

Verify that no errors appear in the JS console

Offline tests

N/A.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

android-mWeb.mp4

Mobile Web - Safari

iOS-mWeb.mp4

Desktop

desktop.mp4

iOS

iOS.mp4

Android

android.mp4

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

melvin-bot · 2023-05-07T11:20:02Z

@techievivek @s77rt One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-05-07T11:25:21Z

What are steps 10 and 11 for?

Prince-Mendiratta · 2023-05-07T11:33:08Z

@s77rt I've noticed that in the current staging, the behaviour can be different when the requests have been throttled, so might as well check for that case. As you would see in the linked issue, the bug was not reproduced when the requests were throttled so we should check for that case.

s77rt · 2023-05-07T11:43:45Z

I don't think this has any effects for the tests here. The bug was not reproducible because we saved the phone number on onyx without the domain and also checked for the existence without the domain. But this used to break when the API response arrives where the phone number is now stored with domain but checking for existence was still done without the domain.

With this PR the phone number will always be stored with domain (and checked with domain). The additional steps are not really required. Step 5 (waiting for opacity with green dot) is enough.

Prince-Mendiratta · 2023-05-07T11:45:12Z

Sounds good, updated OP.

s77rt · 2023-05-07T14:47:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mweb-chrome.mp4

Mobile Web - Safari

mweb-safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

s77rt

LGTM! 🚀

cc @techievivek

techievivek

Looks good 🚀

techievivek · 2023-05-08T07:44:54Z

        const phoneLogin = LoginUtils.appendCountryCode(LoginUtils.getPhoneNumberWithoutSpecialChars(login));
        const parsedPhoneNumber = parsePhoneNumber(phoneLogin);
-        const userLogin = parsedPhoneNumber.possible ? parsedPhoneNumber.number.e164 : login;
+        const userLogin = parsedPhoneNumber.possible ? `${parsedPhoneNumber.number.e164}${CONST.SMS.DOMAIN}` : login;


NAB: Maybe a comment in these cases could be helpful otherwise one wouldn't understand the significance of appending the domain here.

It seems we ended up fixing this twice at the same time. Either way, should leave both fixes? #18473 Even if they are redundant, it will make it more bullet proof? 😄

Not exactly bullet proof 😅 I have commented on the linked PR #18473 (comment).

OSBotify · 2023-05-08T07:51:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-09T03:32:11Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-09T04:04:10Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-09T04:05:30Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: duplicate contact number

f013427

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta requested a review from a team as a code owner May 7, 2023 11:19

melvin-bot Bot requested review from s77rt and techievivek and removed request for a team May 7, 2023 11:20

Prince-Mendiratta mentioned this pull request May 7, 2023

[HOLD for payment 2023-05-16] [$1000] Duplicate phone numbers are accepted as a contact method #18207

Closed

6 tasks

s77rt approved these changes May 7, 2023

View reviewed changes

techievivek approved these changes May 8, 2023

View reviewed changes

techievivek reviewed May 8, 2023

View reviewed changes

techievivek merged commit ab9171f into Expensify:main May 8, 2023

OSBotify mentioned this pull request May 9, 2023

Deploy Checklist: New Expensify 2023-05-09 #18627

Closed

26 tasks

s77rt mentioned this pull request May 9, 2023

Fix: Red dot persists after removing phone number contact method #18473

Merged

57 tasks

Pujan92 mentioned this pull request May 10, 2023

Revert "Fix: Red dot persists after removing phone number contact method" #18705

Merged

55 tasks

Uh oh!

Conversation

Prince-Mendiratta commented May 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 7, 2023

Uh oh!

s77rt commented May 7, 2023

Uh oh!

Prince-Mendiratta commented May 7, 2023

Uh oh!

s77rt commented May 7, 2023

Uh oh!

Prince-Mendiratta commented May 7, 2023

Uh oh!

s77rt commented May 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

techievivek left a comment

Choose a reason for hiding this comment

Uh oh!

techievivek May 8, 2023

Choose a reason for hiding this comment

Uh oh!

pecanoro May 9, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt May 9, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 8, 2023

Uh oh!

OSBotify commented May 9, 2023

Uh oh!

OSBotify commented May 9, 2023

Uh oh!

OSBotify commented May 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Prince-Mendiratta commented May 7, 2023 •

edited

Loading

s77rt commented May 7, 2023 •

edited

Loading