[HOLD for payment 2023-05-16] [$1000] Duplicate phone numbers are accepted as a contact method

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to "Contact method"
2. Click on "New contact method"
3. Enter a phone number
4. Click "Add"
5. Click on "New contact method" again
6. Enter the same phone number as before
7. Click "Add"

Expected result:

The duplicate contact method added should not be shown, and no error should be shown.

Actual result:

Two contact methods with the same phone number are being shown and both have errors.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-04-29.15.54.08.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682773410951039

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014cd7afa4b6e6e6d5
• Upwork Job ID: 1652877111573905408
• Last Price Increase: 2023-05-01

[MelvinBot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

Duplicate phone numbers are accepted as a contact method

What is the root cause of that problem?

Whenever new contact method added it will call submitForm function as shown below:

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Lines 77 to 84 in a786349

	const submitForm = useCallback(() => {
	// If this login already exists, just go back.
	if (lodashGet(props.loginList, login)) {
	Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS);
	return;
	}
	User.addNewContactMethodAndNavigate(login, password);
	}, [login, props.loginList, password]);

We are using lodashGet(props.loginList, login) to check that login already exist within login list or not. So here when we enter phone number in different format at that time key within props.loginList become different so it will not able to detect that phone number already exist within login list. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

Within submitForm() function we have to use LoginUtils.getPhoneNumberWithoutSpecialChars() function and then we have to use it within lodashGet() to check that login key already exist within props.loginList or not. Updated code for submitForm() is as shown below.

const submitForm = useCallback(() => {
    const phoneLogin = LoginUtils.getPhoneNumberWithoutSpecialChars(login); // *** Add this ***

    // If this login already exists, just go back.
    if (lodashGet(props.loginList, phoneLogin))  {  // *** Updated Code
     ....
    }
    ....
}, [login, props.loginList, password]);

This will solve the issue i.e. do not allow to enter same phone number although in different format as shown in result video.

What alternative solutions did you explore? (Optional)

None

Results

18207-DuplicatePhoneNumber.mp4

[Prince-Mendiratta]

I think this issue will be resolved by #18103

cc @s77rt

[s77rt]

Thanks @Prince-Mendiratta. Indeed it shall be fixed by that PR.

[kadiealexander]

Reproduced in desktop app version 1.3.8-8.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~014cd7afa4b6e6e6d5

[MelvinBot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)