Skip to content

[NewContactPage] fix: same number added twice #18536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techievivek merged 1 commit into from
May 8, 2023
Merged

[NewContactPage] fix: same number added twice #18536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/settings/Profile/Contacts/NewContactMethodPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function NewContactMethodPage(props) {
const submitForm = useCallback(() => {
const phoneLogin = LoginUtils.appendCountryCode(LoginUtils.getPhoneNumberWithoutSpecialChars(login));
const parsedPhoneNumber = parsePhoneNumber(phoneLogin);
const userLogin = parsedPhoneNumber.possible ? parsedPhoneNumber.number.e164 : login;
const userLogin = parsedPhoneNumber.possible ? `${parsedPhoneNumber.number.e164}${CONST.SMS.DOMAIN}` : login;

@techievivek techievivek May 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: Maybe a comment in these cases could be helpful otherwise one wouldn't understand the significance of appending the domain here.

@pecanoro pecanoro May 9, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we ended up fixing this twice at the same time. Either way, should leave both fixes? #18473 Even if they are redundant, it will make it more bullet proof? 😄

@s77rt s77rt May 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly bullet proof 😅 I have commented on the linked PR #18473 (comment).


// If this login already exists, just go back.
if (lodashGet(props.loginList, userLogin)) {
Expand Down