Deploy Checklist: New Expensify 2024-04-18

[github-actions]

Release Version: 1.4.63-21
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fixed getting two magic codes upon signing in once #30849
• Add possibility to leave from workspaces and workspace expense chats #35671
• [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript #36314
• Fix: three not found view #36409
• Add edit billable check #37065
• [TS migration] Migrate MoneyTemporaryForRefactorRequestConfirmationList.js component to TypeScript #37181
• Clean up vbba code, save each substep and support vbbas on multiple workspaces #37680
• perf: Implement filtering in search page #37909
• Update welcome note #38023
• 36038 fix selection list footer extra padding 2 #38039
• Add Onyx key to allow remotely resetting client data #38196
• New chat page list refactor 2 #38610
• Feat/track whispers #38709
• Fix/37847 - Show the tags in the first policyTagLists #38759
• Fix - Add BA thread is missing Add button, incomplete thread header and "Hidden" user #38884
• Fix created distance request briefly shows the user local currency instead of the workspace currency #38892
• Refactor some components / screens to use useOnyx #38924
• Fix the optimistic data of hold action isn't consistent with backend data #38980
• fix: tag name in RHP is not correct #38988
• Modify optimistic data to support new text+attachment messages #39007
• Integrate adminAccountID of a report action #39042
• Add new HOC to get policy.connections data #39132
• Add backup transaction again #39144
• [TS migration] Migrate IOURequestStepTag/Participants/Merchant #39186
• Sync keyboard navigation in SelectionList and PopoverMenu #39201
• Authenticate with QBO #39219
• fix: move "Troubleshoot" out of About #39230
• Immediately show file size message for large attachments #39334
• fix unsubscribe is typing event if not focus on screen #39347
• Android - Sign-in page flickers after using autofill #39374
• fix scan expense report and transaction are not hidden #39389
• Fix no error shows when saving personal bank account that exist in workspace BA draft #39398
• Enable creating tasks with short-mentions using the create task commands #39475
• Fix an inconsistency between the mute status icon in full screen mode… #39479
• Fix unread message indicator not displayed after flagging message as offensive #39482
• Renaming money request to expense #39483
• Deprecate POLICY_MEMBERS #39489
• Implement Live Markdown for task descriptions #39519
• Clear hold reason of all transactions when the admin approves all requests #39579
• Add default font size for emojis in live markdown input #39597
• Handle max length for markdown description #39624
• Update the Group Chat creation flow UI and Details page #39639
• Add Track functionality to QAB #39640
• fix: expense chat doesn't scroll to bottom when we create a distance request #39685
• Add markdown for workspace description #39686
• [MentionsV2] Room mentions suggestions #39697
• [Group Chats] Add remaining features #39757
• Fix: Breadcrumbs shows correct workspace when selected via keyboard #39787
• Upgrade onyx to 2.0.27 #39791
• [Fix]: Number of announce room members does not update when remove workspace members due to pendingAction #39796
• Fix: update options when creating task #39811
• Deprecate card.isVirtual references #39829
• Fix message shows up for the admin while there is an approver setup #39846
• Support disable status for the Switch component #39874
• [NO QA] Disable the switch when there is accounting connection #39895
• Fix request preview isn't crossed out when deleting in offline #39903
• [Mentions v2] Parse <mention-report> when displaying reportAction #39906
• fix @expensify.sms is copied along with phone number #39908
• [TS migration] Migrate IOURequestStartPage, IOURequestRedirectToStartPage, IOURequestStepDistance and IOURequestStepAmount pages to TypeScript #39910
• Update the Quick Action Button section name #39912
• Fix mention suggestion highlight doesn't move when the text selection moves #39917
• Fix: button trigger double action on keyup #39924
• [BUGFIX] Onboarding - Modal can be dismissed by ESC key #39927
• Update BottomAvatar Tooltip #39945
• Delete docs/articles/expensify-classic/copilots-and-delegates/Invite-… #39960
• Delete docs/articles/expensify-classic/copilots-and-delegates/Removin… #39962
• fix LHN preview for payment cancellation #39963
• Create Add-expenses-to-a-report.md #39972
• Update HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md #39973
• Create Add-comments-and-attachments-to-a-report.md #39974
• Create Edit-a-report.md #39975
• Create Submit-or-retract-a-report.md #39976
• Update and rename The-Reports-Page.md to Report-statuses.md #39977
• Update and rename Report-Audit-Log-and-Comments.md to Print-or-downlo… #39978
• Update redirects.csv #39987
• Fix join workspace flow #39991
• fix thread shows expensify.sms in header #39994
• Fix "Send" button is missing on password protected PDF preview #39995
• fix: Infinite skeleton loading when navigate #39996
• Update splash theme for web #39997
• Create Business-Bank-Accounts-AUD.md #39998
• Delete docs/articles/expensify-classic/connect-credit-cards/business-… #39999
• Create Deposit-Accounts-USD.md #40000
• Delete docs/articles/expensify-classic/connect-credit-cards/deposit-a… #40001
• Create Business-Bank-Accounts-USD.md #40002
• Delete docs/articles/expensify-classic/connect-credit-cards/business-… #40003
• Create Deposit-Accounts-AUD.md #40004
• Delete docs/articles/expensify-classic/connect-credit-cards/deposit-a… #40005
• Create Global-Reimbursements.md #40006
• feat: bump react-native-screens #40009
• [TS Migration][No QA] Improve routes validation #40017
• deprecate ReportActionUtils.getAllReportActions() (Issue 39091) #40046
• Add 'full' parameter to ApproveMoneyRequestParams #40065
• fix: Video - Console error shows up when playing video #40068
• Refactor layout of WorkspaceListRow #40069
• [Taxes] Display tax rate value in the list #40083
• fix: Inconsistent Padding Between Error Message and Save Button in Tax value section #40088
• [TS migration] Migrate ProfileAvatarWithIndicator.js component to TypeScript #40090
• [Fix]: After page refresh back button opensSave the world page with chat LHN instead of menu list #40091
• [Fix]: BE length and FE limit for Legal Name are not consistent leading to unsaved input without error after submitting #40095
• Migrate IOURequestStepCurrency to TypeScript #40100
• Fix Android build failing due to dependencies being built for wrong ABIs #40102
• [No QA] Check for undefined in promiseWhile.ts - follow-up #40104
• [CP Staging] Comment the QR code download button until it can be fixed #40109
• fix: missing title on disabled input #40113
• feat: bump react-native-airship #40122
• Migrate search page to chat finder page #40129
• [Fix]: Report fields are not auto focused on field selection #40130
• Fix: Inconsistent group chat name in share code page #40134
• fix: Web - Persistence of Tax Selection When Navigating to Other Pages and Returning #40136
• Don't show GBR to AM/guides for managed customer employee invitations #40160
• Fix flickering when reopening settings page #40161
• Scan - No error modal shown after selecting corrupted image. #40162
• Enable creating a group chat with one other participant #40165
• Fixing not here page in empty notes #40166
• Unpausing the queue when we receive Pusher updates while we're still loading the App #40169
• Only show the QR code and not the download button  #40171
• feat: bump react-native-geolocation #40174
• Fix inconsistent color in group counter #40175
• Workspace switcher page list refactor #40179
• Revert "Unpausing the queue when we receive Pusher updates while we're still loading the App" #40183
• Fix param type #40196
• Fix task description update message doesn't parse the markdown #40200
• [HelpDot] fix numbering #40207
• fix: No hover effect for selected options. #40215
• fix: Web - Inconsistent behavior of tag disappearing and reappearing when requesting money. #40217
• Enable live markdown in IOU request descriptions #40224
• update version react native live markdown #40228
• fix error message appears briefly after changing tax rate #40229
• Update to correct NVP name #40230
• Update Zenefits.md to say Zenefits #40231
• Issue 39091 - use waitForCollectionCallback #40233
• Add shouldSyncFocus prop to ListItem components #40234
• Fix user mention auto complete selection #40238
• Fix report header in one transaction report has extra spacing #40268
• Fix skeleton displays when opening a unaccess or not found report #40273
• Fix video play control broken after coming back from thread #40275
• Room mentions composer #40279
• fix delete menu item appearing bug for iou type parent message #40287
• [NoQA] Do not allow new js files in other folders either #40291
• Copy changes for Track QAB #40325
• Update custom messages in the onboarding flow #40328
• Fix chat icon is highlighted after returning from share log page #40330
• Fix after adding Debit Card user is directed to /home url and white blank page #40333
• fix: Skeleton of money request preview has no animation #40335
• Remove duplicate redirect #40349
• Update eslint lib version #40359
• [HelpDot] verify that redirects.csv does not contain any duplicate keys #40378
• Fix/pdf not showing for money request #40385
• [CP Stg] Fix assignment of selectedItemIndex in PopoverMenu #40425
• [CP Stag] Fix workspace role change options #40428
• Fix scrolling to last index in SelectionList using keyboard #40439
• fix: Submit Expense - Error message about corrupted file when dragging and dropping image receipt #40471
• [CP Staging] FormWrapper bottom padding fix #40473
• [CP Staging]Revert "Immediately show file size message for large attachments" #40510
• [CP Staging] Remove quick action report when leaving group chat #40511
• [CP Staging] Fix default selection in workspace switcher #40522
• Revert "Fix task description update message doesn't parse the markdown" #40525
• Revert - #36409 "Fix: three not found view" #40526
• [CP Staging] Fix selecting items and animating Pages with SelectionList #40562
• [CP Staging] [Group Chats] Fixes for Thread Avatars and Leave Group Chat Navigation #40563
• [CP Staging] Fix: align badge in workspace list #40599
• [CP Staging] Use correct, new transactions backup key for Money Request amounts #40605
• [CP Staging] fix: disable double press event handler #40642
• [CP Staging] fix: IOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list. #40645
• [CP Staging] fixes track whispers follow up minor issues #40648
• [CP Staging] Fix/40543: IOU - Currency in the amount editor is USD when the request is created in local currency #40655
• [CP Staging] Revert "Fixed getting two magic codes upon signing in once" #40690

Deploy Blockers:

• [HOLD for payment 2024-05-03] [$1000] Android - LHN - Unable to open reports, tasks and threads in LHN #40048
• [$1000] Android - Unable to access popup menu while "New message" marker is visible #40108
• [$250] iOS - Chat - Emojis are not displayed properly in the emoji picker #40360
• [HOLD for payment 2024-05-20] IOU - No bottom margin below the Save button in Merchant page #40397
• FAB – Blue frame appears when navigate via FAB menu using Up/Down keys #40398
• Chat – Unable to open any + menu option using Up keys and Enter, when open it first time #40399
• [HOLD for payment 2024-06-05] [$250] Chat - Text with attachment message can be edited when the attachment is uploading #40400
• Start chat - App crashes when pressing keyboard up key in Start chat list #40401
• [HOLD for payment 2024-07-24] [$250] Room - Room mention is not copied to clipboard and editor is empty when editing room mention #40403
• Group chat - Search field in Start chat list is not responsive after leaving group chat #40405
• [HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] CRITICAL: [Actionable Whispers] [$500] Workspace list doesn't show up after creating a workspace for categorize it #40406
• Chat - "Auth CreateReportAction returned an error" when sending #mention in non-room chat #40407
• [HOLD for payment 2024-06-06] [$250] [Held requests] Reason appears bolded briefly after holding the request #40408
• [$250] Tag - Tag list scrolls up when selecting a tag from the list #40410
• [Awaiting payment]Workspace members - Missing Make admin and Make member button in the dropdown menu #40411
• [$125] Chat - Emoji is top-aligned instead of centered in the composer #40412
• Task – Long string appears instead of assignee in system message when assigning task #40413
• [HOLD for payment 2024-06-05] Web - Chat - Console error shows up when selecting a phone number mention #40414
• [HOLD for payment 2024-06-03] [$250] Workspace - Admin can access member details side bar after member leaves workspace #40416
• Workspace - Workspace chat member list does not remove user when user has left the chat #40417
• Track expense-Deleting track expense displays expensify message for a second & in LHN #40421
• [$250] Group - ‘Make member’ option is displayed when selecting a member #40422
• Search - Searched results on the list are not filtered correctly #40424
• [$250] Group - ‘Notification preferences’ page transition animation is broken #40426
• Group - Offline added avatar is not showing with reduced opacity #40427
• Group - Selected members are not highlighted #40429
• [PAID] [$250] Group - ‘Next’ button size is not consistent with ‘Start group’ button size #40430
• Group - Offline added avatar doesn't persist #40433
• [HOLD for payment 2024-05-09] [$250] iOS - Scan - Receipt preview in confirmation page has sharp instead of round corners #40436
• [$250] Submit Expense - Error message about corrupted file when dragging and dropping image receipt #40440
• [$250] iOS - Profile - Missing circle at the center of avatar preview when uploading new avatar #40441
• [HOLD for payment 2024-05-02] [$250] Group chat - Removed member can be clicked on when removed offline #40442
• [HOLD for payment 2024-04-29] "Share Somewhere" Option Disabled Despite Task Assignment #40452
• [$250] Workspace switcher - Selected filter is not highlighted #40454
• Android - Onboarding - Tapping the Onboarding link does not open the Onboarding menu #40456
• [HOLD for payment 2024-05-02] [$250] Group chat - No tooltip when hovering over group member name in the chat header #40457
• [$250] Onboarding- After finishing "onboarding" and switching to DM, an error appears in the console #40458
• [$250] Workspace - mweb - Invited members disappears from workspace members list #40459
• Android - Login - When entering the magic code and signing in, a gray and black screen appears. #40462
• [$250] [HOLD for payment 2024-05-06] Group - Wrong number of members seen on group details page #40463
• [$250] Group chat - Implement offline behavior for UpdateGroupChatMemberRole #40465
• [PAID] [$250] Group chat - Members RHP shows offline indicator #40466
• [$250] Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link #40467
• [$250] Thread - Unable to upload photo for thread avatar from group chat #40470
• [HOLD #40412] Live MD - No top margin for only emojis inside the expanded compose box #40472
• [$250] Group chat - User can return to group chat after leaving the group chat via back button #40474
• Submit Expense - 'No PDF file specified' shown on confirmation page after adding PDF receipt #40476
• [HOLD for payment 2024-07-24] [$250] Group chat - User mention is not copied when copying "made an admin" whisper to clipboard #40477
• [HOLD for payment 2024-06-20] [$250] Web - IOU - Currency listing page displays empty when clicked on currency #40483
• CRITICAL: [Actionable Whispers] Track scan expense is duplicated when it is submitted to someone #40485
• Submit Expense - PDF files can not be added to scan expense on mobile apps #40486
• Bottom button on transfer balance, Merchant and status pages are missing padding #40489
• [HOLD for payment 2024-05-02] CRITICAL: [Actionable Whispers] [$500] Unable to return to invite page after returning to confirmation page #40490
• Chat - File types MP4, PDF, DOC etc other than images can not be attached to a report #40492
• [PAID] [$250] Leaving a group chat with 0 members inside still populates the search as a result #40493
• Magic code not received when SAML enabled and Required for sign in disabled #40498
• [HOLD for payment 2024-05-08] [$250] Task - "From" subtitle is present in group task report after user has left the group #40499
• [$250] Android - Chat - Changing skin tone and selecting emoji moves cursor to left #40504
• [$250] Web - Scan - Selecting tag via Enter key directly returns to first step of Scan request #40507
• [HOLD for payment 2024-08-02] [$250] Android - Not found page closes prematurely when navigating to invalid WS links #40509
• [HOLD for payment 2024-05-09] [$250] Group chat - Inconsistency in limitation when adding members via FAB and group details page #40512
• [Wave Collect][QBO] Accounting - QBO menu only appears after revisiting Accounting after synchronization #40513
• [HOLD for payment 2024-05-09] [Wave Collect][QBO] iOS - Accounting - App crashes after completing QBO setup flow #40517
• [HOLD for payment 2024-05-03] [$250] Room - Description Error Message is overlapped by highlight #40519
• [C+ Checklist Needs Completion] CRITICAL: [Actionable Whispers] [$250] Categorize it - No workspace found appears briefly after clearing search field #40520
• [Pay meow][$250] Workspace - Workspace type name is not showing in correct column #40524
• [HOLD for payment 2024-05-09] [$250] Emojis - Large emoji is cut off in preview on iOS and Android app #40535
• [HOLD for payment 2024-05-06] [$250] Quick action - Group chat name and avatar does not update unless the page is refreshed #40536
• [$250] Scan split - Confirmation page & Category RHPs appear together when opening Category #40538
• [HOLD for payment 2024-05-02] Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40539
• [$250] Expense - Missing Members section in expense report details page #40541
• [$250] Hold request - Duplicate expense info shown if partially approving report with on hold expense #40542
• IOU - Currency in the amount editor is USD when the request is created in local currency #40543
• [$250] Share code - For split expense, share code is showing E logo in center of QR code. #40546
• Track expense - Categorize it - Email result shows up and it leads to not here page #40549
• [$250] RHP - Notification preference panel shows different behavior when opening #40550
• [HOLD for payment 2024-05-13] [$250] Web - Pressing on keyboard enter key on notification option of a room takes back two steps #40551
• [HOLD for payment 2024-05-06] [$125] Sending image with message has ' appears as HTML for temporarily until the image appears fully #40578
• Pay someone - Letter "s" in "Pay someone" banner is capitalised #40581
• [HOLD for payment 2024-05-06] [$250] Web - Group chat - Three presses on down arrow are required to bring selection back to top #40583
• [$250] Group chat - Custom avatar reverts to default avatar after promoting member to Admin #40586
• [$250] GRP chat - Invalid group chat name error still persists after clearing group name text #40587
• [$500] Workspace - Endless skeleton loader on the member page if you switch to it multiple times #40595
• [HOLD for payment 2024-05-09] [$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list #40597
• Web - Login page - Stack with 'E' logo under specific Mac/Safari versions #40603
• [$250] IOU - Unable to change currency in transaction thread #40631
• [HOLD for payment 2024-05-06] [$250] Join workspace - Unapproved workspace appears in workspace switcher #40679
• [Awaiting checklist] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN #40680
• [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] mWeb/Safari - UI - The top part of the UI is white while the page is loading in dark mode #40683

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.63-0 🚀

[kbecciv]

Internal QA - #38196, checking off
No QA - #39132, #39874, #40183, #40196, #40359, checking off
Prod QA - #39960, #39976, #39977, #39978, #39998, #40000, #40002, #40004,
#40006, #40207, #40378 - checking off

[Beamanator]

Checked off #40405 b/c it wasn't reproducible by a few people

[rlinoz]

Checking off #40360 as it was from the previous checklist.

[twisterdotcom]

Checking off #40412 as it's not a blocker.

[tgolen]

Checking off #40458 as not a blocker

[rlinoz]

Demoting #40463

[amyevans]

Checked off #40429 as intended design

[rlinoz]

Demoting #40422

[marcaaron]

Demoting #40427

[amyevans]

Demoting #40465

[marcaaron]

Demoting #40426