[PAID] [$250] Group chat - Members RHP shows offline indicator

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to FAB > Start chat.
4. Create a group chat.
5. Click on the chat header in the group chat.
6. Click Members.

Expected Result:

Members RHP will not show offline indicator (production behavior).

Actual Result:

Members RHP shows offline indicator.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453462_1713436112907.20240418_182449.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016859f51dea712595
• Upwork Job ID: 1780980589354110976
• Last Price Increase: 2024-04-18
• Automatic offers:
• Nodebrute | Contributor | 0

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group chat - Members RHP shows offline indicator

What is the root cause of that problem?

It's because of this

App/src/pages/ReportParticipantsPage.tsx

Line 312 in 9b839f4

shouldShowOfflineIndicatorInWideScreen

What changes do you think we should make in order to solve the problem?

We should remove this

App/src/pages/ReportParticipantsPage.tsx

Line 312 in 9b839f4

shouldShowOfflineIndicatorInWideScreen

What alternative solutions did you explore? (Optional)

[neil-marcellini]

@Nodebrute thanks for the proposal. Can you provide some more insight into why that prop was set and if any other pages or areas of the app need to display the offline indicator on the members page?

I imagine that some pages display the members in the main pain vs the RHP, so those pages need to show the offline indicator.

After looking more carefully, I see that the ReportParticipantsPage is only displayed in the RHP, so it should be fine for this to never show the offline indicator in wide screen.

Proposal looks good, assigning @Nodebrute

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016859f51dea712595