[Mentions v2] Parse <mention-report> when displaying reportAction by war-in · Pull Request #39906 · Expensify/App

war-in · 2024-04-09T09:20:34Z

Details

Fixed Issues

$ #39545
PROPOSAL:

Tests

To check the functionality paste the code in src/pages/home/report/ReportActionsView.tsx under the PopoverReactionList (line 533)

<RenderHTML html="<comment><mention-report>#admins</mention-report></comment>" />
<RenderHTML html='<comment><mention-report reportID="3088255940953979" /></comment>' />
<RenderHTML html="<comment><mention-report>#non-existent-room</mention-report></comment>" />
<RenderHTML html='<comment><mention-report reportID="111111" /></comment>' />

Go to a chat
There should be some tags
The first one is clickable and redirects to the #admins room
The second one is clickable and redirects to the chat of id 3088255940953979 (you probably would need to change the id to one existing on your account)
Last two should not redirect because there are no such rooms

Offline tests

QA Steps

To check the functionality paste the code in src/pages/home/report/ReportActionsView.tsx under the PopoverReactionList (line 533)

<RenderHTML html="<comment><mention-report>#admins</mention-report></comment>" />
<RenderHTML html='<comment><mention-report reportID="3088255940953979" /></comment>' />
<RenderHTML html="<comment><mention-report>#non-existent-room</mention-report></comment>" />
<RenderHTML html='<comment><mention-report reportID="111111" /></comment>' />

Go to a chat
There should be some tags
The first one is clickable and redirects to the #admins room
The second one is clickable and redirects to the chat of id 3088255940953979 (you probably would need to change the id to one existing on your account)
Last two should not redirect because there are no such rooms

PR Author Checklist

Screenshots/Videos

Android: Native

android.-.native.mov

Android: mWeb Chrome

android.-.web.mov

iOS: Native

ios.-.native.mov

iOS: mWeb Safari

ios.-.web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-04-10T09:28:53Z

@Ollyws @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2024-04-10T10:10:05Z

Linking to another room only seems to work from rooms, not from a normal chat. navigationRoute seems to be undefined when attempting to navigate from a normal chat:

Screen.Recording.2024-04-10.at.12.07.25.mov

puneetlath · 2024-04-10T15:11:15Z

I think we should call the renderer MentionReport instead of MentionRoom since the tag is <mention-report>

robertKozik · 2024-04-10T19:20:19Z

Linking to another room only seems to work from rooms, not from a normal chat. navigationRoute seems to be undefined when attempting to navigate from a normal chat:

Actually @rlinoz @puneetlath When user types by hand room mention (auto complete is disabled for chats which are not in group policy) we will parse it and send to backend (parser is not aware of chat type). Will backend filtered this tag out?

robertKozik · 2024-04-10T19:22:03Z

I think we should call the renderer MentionReport instead of MentionRoom since the tag is <mention-report>

Changed 👌🏼

rlinoz · 2024-04-10T19:41:45Z

Will backend filtered this tag out?

Yes, if a mention happens outside of a specific policy we will remove the tag.

robertKozik · 2024-04-10T19:44:17Z

So if we have only optimistic version of the report action the expected behaviour would be to check if mentions are allowed in current report and if not just return null and not render it at all?

rlinoz · 2024-04-10T20:08:29Z

I think we should strip out the tag and render as plain text if the mention is happening in a report that is not allowed.

rlinoz · 2024-04-11T21:30:30Z

I think we should strip out the tag and render as plain text if the mention is happening in a report that is not allowed.

Just to be sure, we are going to do that in this PR right?

robertKozik · 2024-04-11T22:34:19Z

Yeah @war-in will take care of it tommorow

war-in · 2024-04-12T11:10:10Z

@Ollyws fixed! Now, linking from the chat is disabled as @rlinoz requested

Ollyws · 2024-04-12T13:29:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

melvin-bot · 2024-04-12T13:30:33Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #39545 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

war-in · 2024-04-12T14:53:12Z

@rlinoz fixed 😌

rlinoz

Thanks!

OSBotify · 2024-04-18T04:57:08Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2024-04-18T05:53:36Z

@war-in Can you verify internally, not sure if QA team can paste the code in src/pages/home/report/ReportActionsView.tsx under the PopoverReactionList (line 533)?

robertKozik · 2024-04-18T10:37:46Z

@kbecciv As I saw that other PR's related to mentions are deployed as well, you should be able to just type the mention inside composer - sent message should contain the mention and be styled properly.

OSBotify · 2024-04-22T14:58:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 · 2025-04-01T17:47:05Z

+
+        // eslint-disable-next-line rulesdir/prefer-early-return
+        Object.values(reports ?? {}).forEach((report) => {
+            if (report?.policyID === currentReport?.policyID && removeLeadingLTRAndHash(report?.reportName ?? '') === mentionDisplayText) {


Ref: #58361, we should add the condition to get the room only

war-in added 5 commits April 8, 2024 18:45

wip

b9b7952

done

9055134

remove test code

02b56f7

fix unexpected behaviour on android

0caff86

make code prettier

af8efd4

robertKozik reviewed Apr 9, 2024

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/MentionRoomRenderer.tsx Outdated

robertKozik reviewed Apr 9, 2024

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/MentionRoomRenderer.tsx Outdated

robertKozik reviewed Apr 9, 2024

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/MentionRoomRenderer.tsx Outdated

robertKozik reviewed Apr 9, 2024

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/MentionRoomRenderer.tsx Outdated

war-in added 2 commits April 9, 2024 14:32

wip

61b7f77

review suggestions

e563db0

war-in requested a review from robertKozik April 9, 2024 13:37

war-in marked this pull request as ready for review April 10, 2024 09:28

war-in requested a review from a team as a code owner April 10, 2024 09:28

melvin-bot Bot removed request for a team and robertKozik April 10, 2024 09:28

melvin-bot Bot requested a review from Ollyws April 10, 2024 09:28

change name to MentionReportRenderer

9dcc78d

prettier

3aa0c5d

robertKozik reviewed Apr 12, 2024

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer.tsx Outdated

disable linking in non-policy chats

19b670a

war-in requested a review from robertKozik April 12, 2024 10:48

rename props to match component name

6d8c349

Ollyws approved these changes Apr 12, 2024

View reviewed changes

rlinoz requested review from rlinoz and removed request for robertKozik April 12, 2024 13:30

rlinoz requested changes Apr 12, 2024

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer.tsx

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer.tsx Outdated

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer.tsx Outdated

war-in added 2 commits April 12, 2024 16:49

fix double ## for room mentions

55fc7f0

typos

052e4ce

war-in requested a review from rlinoz April 12, 2024 14:52

puneetlath approved these changes Apr 12, 2024

View reviewed changes

rlinoz approved these changes Apr 12, 2024

View reviewed changes

rlinoz merged commit 44de443 into Expensify:main Apr 12, 2024

rlinoz mentioned this pull request Apr 15, 2024

Revert "[Mentions v2] Parse <mention-report> when displaying reportAction" #40237

Closed

github-actions Bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

kbecciv mentioned this pull request Apr 19, 2024

Chat - Mention containing valid report ID is not clickable and invalid # is not styled #40582

Closed

6 tasks

war-in deleted the war-in/mention-room-renderer branch June 24, 2024 09:49

dukenv0307 reviewed Apr 1, 2025

View reviewed changes

Uh oh!

Conversation

war-in commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 10, 2024

Uh oh!

Ollyws commented Apr 10, 2024

Uh oh!

puneetlath commented Apr 10, 2024

Uh oh!

robertKozik commented Apr 10, 2024

Uh oh!

robertKozik commented Apr 10, 2024

Uh oh!

rlinoz commented Apr 10, 2024

Uh oh!

robertKozik commented Apr 10, 2024

Uh oh!

rlinoz commented Apr 10, 2024

Uh oh!

rlinoz commented Apr 11, 2024

Uh oh!

robertKozik commented Apr 11, 2024

Uh oh!

Uh oh!

war-in commented Apr 12, 2024

Uh oh!

Ollyws commented Apr 12, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

war-in commented Apr 12, 2024

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

kbecciv commented Apr 18, 2024

Uh oh!

robertKozik commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

dukenv0307 Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

war-in commented Apr 9, 2024 •

edited

Loading

robertKozik commented Apr 18, 2024 •

edited

Loading