Skip to content

[test-qa-hourly] Cover CRLF TTS separator cleanup#106

Merged
david30907d merged 1 commit into
mainfrom
test-qa/ongoing-coverage-20260713
Jul 14, 2026
Merged

[test-qa-hourly] Cover CRLF TTS separator cleanup#106
david30907d merged 1 commit into
mainfrom
test-qa/ongoing-coverage-20260713

Conversation

@taiiiiiiiiiiii

Copy link
Copy Markdown
Contributor

Summary

  • Add a focused regression test for Windows-style CRLF input in cleanTextForTts.
  • Verifies standalone Markdown separators are removed without converting the script's newline convention.

Inspected

  • Open Test QA PRs: none; prior [test-qa-hourly] Cover Tenderly simulation timeout #101 is merged.
  • Recent commits on main, including the TTS text-cleansing implementation.
  • Existing cleanser unit tests and implementation behavior.
  • Latest main commit status available through GitHub.

Commands / validation

  • Not run locally: this automation run has GitHub connector access only.
  • Focused intended validation: pnpm turbo run test --filter=@zapengine/podcast-pipeline -- --run src/services/ingest/tts-text-cleansing.test.ts.
  • Broader intended validation: pnpm verify changed and GitHub CI.

QA scope

  • One test-only file changed.
  • No CI gates weakened.
  • No docs/agent files changed.
  • No secrets included.

Auto-merge

  • Enable only after the PR is labeled, mergeable, and required GitHub checks pass. Repository auto-merge availability remains the source of truth.

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
zap-engine-frontend Ready Ready Preview, Comment Jul 13, 2026 1:06am
zap-engine-landing-page Ready Ready Preview, Comment Jul 13, 2026 1:06am

@taiiiiiiiiiiii taiiiiiiiiiiii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test QA run summary

  • Reused open Test QA PR #106 and reviewed its current diff and metadata.
  • CI status: GitHub CI #632 completed successfully. Jobs checked: lint-test, coverage, deploy-gates, check-dead-env, and verify-fly-docker; deploy-fly skipped as expected.
  • Vercel preview deployments for the frontend and landing page are Ready.
  • Diff scope remains test-only: 1 file, +6 lines, covering CRLF-preserving TTS separator cleanup.
  • No new commit was pushed this run because the existing change is already the smallest coherent QA improvement and all validation is green.
  • Commands: no local commands were run because this run has GitHub connector access only. GitHub CI #632 is the source-of-truth validation and passed.
  • test-qa label confirmed.
  • Auto-merge attempt failed because repository-level auto-merge is disabled.
  • Next QA target after merge: mixed-newline input or empty / separator-only podcast ingest scripts, with behavior assertions around the returned validation error.

@taiiiiiiiiiiii taiiiiiiiiiiii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test QA run summary

  • Continued existing Test QA PR #106 and reviewed its current one-file test-only diff.
  • CI status: GitHub Actions run #632 completed successfully. Jobs checked: lint-test, coverage, deploy-gates, check-dead-env, and verify-fly-docker; deploy-fly skipped as expected.
  • QA change status: no additional commit pushed this run. The current CRLF regression test remains a small coherent change and is already fully validated, so extending the PR would add unnecessary scope.
  • Commands / validation: no local commands run because this run has GitHub connector access only. GitHub CI #632 is the source-of-truth validation and passed.
  • Scope review: one test file only; no CI gates weakened, no docs/agent files changed, and no secrets.
  • Auto-merge: still blocked because repository-level auto-merge is unavailable.
  • Next QA target after merge: mixed-newline input, or validation behavior for blank / separator-only podcast scripts.

Copy link
Copy Markdown
Contributor Author

Test QA run summary

  • Reused and reviewed the active Test QA PR [test-qa-hourly] Cover CRLF TTS separator cleanup #106.
  • Confirmed the PR base SHA still matches the latest main commit (5a00b97e19887ffcd1901e46fe51f92d59cb5ff9); no branch sync was needed.
  • Reviewed the full test-only patch, the TTS cleanser implementation, existing cleanser tests, recent commits, .github/workflows/ci.yml, and repository auto-merge settings.
  • CI run #632 completed successfully: lint-test, coverage, deploy-gates, check-dead-env, and podcast-pipeline verify-fly-docker passed; deploy-fly was skipped as expected for a pull request.
  • No additional commit was pushed. The existing CRLF regression test is already a small coherent change, and mixed-newline behavior lacks an explicit contract; adding an assumption-based test would increase scope without clear confidence value.
  • Local commands were not run because this run has GitHub connector access only. GitHub Actions CI #632 is the source-of-truth validation.
  • Auto-merge remains unavailable because repository setting allow_auto_merge=false.
  • Next QA target after [test-qa-hourly] Cover CRLF TTS separator cleanup #106 merges: trace the podcast ingest path for empty or separator-only scripts and add a behavior-level validation/error test if the route/service contract clearly defines the expected failure.

@taiiiiiiiiiiii taiiiiiiiiiiii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test QA run summary

  • Rechecked open Test QA PRs and continued #106.
  • Confirmed the PR is open, non-draft, mergeable, based on the current main SHA, and limited to one test-only file (+6 lines).
  • Reviewed the active patch: the test verifies standalone TTS separators are removed while preserving CRLF newlines.
  • GitHub Actions CI #632 completed successfully. Passing jobs: lint-test, coverage, deploy-gates, check-dead-env, and verify-fly-docker; deploy-fly was skipped as expected.
  • No additional commit was added because the current change is already a small coherent regression test and further expansion would create unnecessary scope.
  • Commands run locally: none; this run has GitHub connector access only. GitHub CI #632 is the source-of-truth validation.
  • Auto-merge was attempted again and remains blocked because repository-level auto-merge is disabled.
  • Next QA target after merge: validate podcast ingest behavior for blank or separator-only scripts, provided the service/route contract defines an observable validation error.

@taiiiiiiiiiiii taiiiiiiiiiiii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test QA run summary

  • Continued existing Test QA PR #106; no overlapping PR opened.
  • Inspected recent main commits, PR metadata, current test-only diff, CI workflow run #632, and all jobs in that run.
  • Branch sync: PR base SHA matches the current latest main commit (5a00b97), so no sync commit was needed.
  • CI status: successful. lint-test, coverage, deploy-gates, check-dead-env, and verify-fly-docker passed; deploy-fly was skipped as expected.
  • QA change status: no new commit this run. The existing one-file, +6-line CRLF regression test remains the smallest coherent change; adding another behavior without a clear contract would create noise.
  • Commands: no local commands were run because this run has GitHub connector access only. GitHub Actions CI #632 is the source-of-truth validation.
  • Label: confirmed test-qa is present.
  • Auto-merge: attempted again after confirming the policy conditions, but GitHub rejected it because repository-level auto-merge is disabled.
  • Next recommended QA target after merge: inspect podcast ingest behavior for blank or separator-only scripts and add a validation-error test only if the service or route contract is explicit.

@taiiiiiiiiiiii taiiiiiiiiiiii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test QA run summary

  • Reused open Test QA PR #106 and rechecked its metadata, active diff, recent main commits, and GitHub Actions CI #632.
  • Sync status: PR base SHA still matches the latest main commit (5a00b97e...), so no branch sync was required.
  • CI status: lint-test, coverage, deploy-gates, check-dead-env, and verify-fly-docker all passed; deploy-fly skipped as expected.
  • Diff scope remains test-only: 1 file, +6 lines, covering CRLF-preserving TTS separator cleanup.
  • No commit was pushed this run because the current change is already the smallest coherent QA improvement and adding speculative mixed-newline behavior would expand scope without a documented contract.
  • Commands: no local commands were run because this run has GitHub connector access only. GitHub CI #632 is the source-of-truth validation and passed.
  • Auto-merge remains unavailable because repository-level auto-merge is disabled.
  • Next QA target after merge: inspect podcast ingest behavior for blank or separator-only scripts and add a validation-error behavior test only if the service/route contract is explicit.

Copy link
Copy Markdown
Contributor Author

Test QA run summary — 2026-07-13 19:58 JST

  • Rechecked open Test QA PR [test-qa-hourly] Cover CRLF TTS separator cleanup #106, latest main, active diff, PR mergeability, and GitHub Actions CI #632.
  • main remains at 5a00b97; PR base is current and no branch sync is required.
  • CI remains green: lint-test, coverage, deploy-gates, check-dead-env, and verify-fly-docker passed; deploy-fly skipped as expected.
  • No new commit: the current one-file, +6-line CRLF regression test is already the smallest coherent QA change, and adding speculative behavior would create noise.
  • Commands: no local commands were available; GitHub Actions CI #632 is the source-of-truth validation.
  • Auto-merge remains blocked because repository-level auto-merge is disabled.
  • Next QA target after merge: verify the explicit service/route contract for blank or separator-only podcast scripts, then add a behavior test only if a validation error is defined.

@taiiiiiiiiiiii taiiiiiiiiiiii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test QA run summary

  • Rechecked PR #106 against the latest main; base SHA remains current, so no branch sync was needed.
  • Reviewed the active diff: one test-only file, +6 lines, covering CRLF preservation while removing standalone TTS separators.
  • GitHub Actions CI run #632 remains completed successfully.
  • No new commit added this run because the current change is already the smallest coherent regression test and further expansion would add speculative scope.
  • Local commands were not run; this run has GitHub connector access only. GitHub CI #632 remains the source-of-truth validation.
  • Auto-merge remains unavailable because repository-level auto-merge is disabled.
  • Next QA target after merge: define and test podcast ingest behavior for empty or separator-only scripts, if the service/route contract exposes a clear validation error.

@taiiiiiiiiiiii taiiiiiiiiiiii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test QA run summary

  • Reused open Test QA PR #106 and rechecked the latest main, PR metadata, mergeability, active diff, relevant TTS cleanser implementation/tests, GitHub Actions run #632, and repository settings.
  • Branch sync: not required; PR base SHA 5a00b97e... still matches the latest main commit.
  • CI status: run #632 completed successfully. lint-test, coverage, deploy-gates, check-dead-env, and verify-fly-docker passed; deploy-fly skipped as expected.
  • Diff remains test-only: 1 file, +6 lines, covering CRLF-preserving standalone separator cleanup. No CI gates, docs/agent files, implementation code, or secrets changed.
  • No new commit was pushed because the current test is already the smallest coherent QA improvement and no additional behavior contract was clear enough to justify expanding scope.
  • Commands: no local commands were run because this run has GitHub connector access only. GitHub Actions #632 is the source-of-truth validation and passed.
  • Auto-merge remains unavailable because repository setting allow_auto_merge=false.
  • Next QA target after merge: establish the expected behavior for blank or separator-only podcast scripts at the ingest/service boundary, then add a focused validation-error test if the contract is explicit.

@taiiiiiiiiiiii taiiiiiiiiiiii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test QA run summary

  • Reused open Test QA PR #106 and rechecked PR metadata, mergeability, current test-only diff, and the latest workflow run for head 52cc274d.
  • GitHub Actions CI #632 remains completed successfully.
  • The branch is still clean against main; no sync was required.
  • No new commit was pushed because the existing +6-line CRLF regression test is already the smallest coherent QA change, and adding speculative mixed-newline behavior would create noise without a clear contract.
  • Commands: no local commands were available in this run; GitHub Actions CI #632 remains the source-of-truth validation.
  • Auto-merge remains blocked because repository-level auto-merge is disabled.
  • Next QA target after merge: verify the intended ingest/service behavior for empty or separator-only podcast scripts, then add a focused validation-error test if the contract is explicit.

@david30907d david30907d merged commit 60107b0 into main Jul 14, 2026
9 checks passed
@david30907d david30907d deleted the test-qa/ongoing-coverage-20260713 branch July 14, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants