[test-qa-hourly] Cover Tenderly simulation timeout

[david30907d]

Summary

• Extend the existing Tenderly simulation fetch failure spec with the AbortError timeout path.
• Verifies timeout failures fail closed as unavailable, preserve skipped call evidence, and avoid share URLs / simulation IDs.

Inspected

• Open Test QA PR search: none open; prior [test-qa-hourly] Cover Tenderly core fetch failure #99 is merged.
• Recent PRs: [skills-daily] document connector-only format loops #100 and [test-qa-hourly] Cover Tenderly core fetch failure #99 are merged; [test-qa-hourly] Cover Tenderly core fetch failure #99 added the existing Tenderly fetch failure spec.
• CI workflow: .github/workflows/ci.yml jobs lint-test, check-dead-env, coverage, deploy gates, and Fly Docker verification.
• Test scripts: root package.json and apps/account-engine/package.json.
• Implementation: apps/account-engine/src/services/tenderly-simulation.service.ts core fetch catch path.
• Existing test: apps/account-engine/test/unit/services/tenderly-simulation-fetch-error.spec.ts.

Commands / validation

• Not run locally: repository access is through the GitHub connector in this automation run.
• Focused intended validation: pnpm --filter @zapengine/account-engine test -- test/unit/services/tenderly-simulation-fetch-error.spec.ts.
• Broader intended validation: pnpm --filter @zapengine/account-engine type-check, pnpm --filter @zapengine/account-engine format:check, and GitHub CI.
• GitHub CI should validate this PR after creation.

QA scope

• One test-only change.
• No CI gates weakened.
• No docs/agent files changed.
• No secrets included.

Auto-merge

• To be attempted only if PR metadata and checks satisfy the Test QA policy. Repository currently reports allow_auto_merge=false, so auto-merge is expected to be unavailable.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
zap-engine-frontend	Ready	Preview, Comment	Jul 9, 2026 3:11am
zap-engine-landing-page	Ready	Preview, Comment	Jul 9, 2026 3:11am

[taiiiiiiiiiiii]

QA run summary:

• Inspected recent commits on main, open Test QA PR policy targets, PR #101 metadata/diff, repository settings, CI status for head ccdbc96675f25a81b5f0092e498b6b386dcad936, Vercel statuses, and relevant Tenderly simulation service/tests.
• Continued existing Test QA PR #101; no new branch or overlapping PR created.
• No new commit pushed this run. The current PR diff is still one test-only file: apps/account-engine/test/unit/services/tenderly-simulation-fetch-error.spec.ts.
• CI: GitHub Actions CI run #616 completed successfully; Vercel frontend and landing-page statuses are success.
• Commands: no local commands run in this connector-only automation run. Relevant validations are covered by GitHub CI #616; intended focused command remains pnpm --filter @zapengine/account-engine test -- test/unit/services/tenderly-simulation-fetch-error.spec.ts.
• Auto-merge: not enabled because repository setting allow_auto_merge=false; no force merge or protection bypass attempted.
• Next QA target after #101 merges: add a focused test for Tenderly share-link timeout/non-fatal sharing failure so successful simulations remain valid even when publishing the public simulation URL times out.

[taiiiiiiiiiiii]

Test QA run summary

Inspected

• Open Test QA PR policy target: continued existing [test-qa-hourly] Cover Tenderly simulation timeout #101 ([test-qa-hourly], branch test-qa/ongoing-coverage-20260709).
• Recent main: latest commit 7120206981567f4595808067554539fcab6ea078; Vercel statuses were green before this PR update.
• PR metadata: open, non-draft, mergeable.
• Current PR diff: test-only changes in:
  • apps/account-engine/test/unit/services/tenderly-simulation-fetch-error.spec.ts
  • apps/account-engine/test/unit/services/tenderly-simulation-sharing-error.spec.ts
• Implementation inspected: apps/account-engine/src/services/tenderly-simulation.service.ts, especially core simulate timeout handling and share-link error fallback.

Change made

• Added a focused regression test that keeps a successful Tenderly simulation valid when the public sharing request times out.
• The test verifies status: passed, empty shareUrls, preserved simulationIds, exactly two fetch attempts, and a warning with the timed-out simulation id.

Commands / validation

• Not run locally: repository access is through the GitHub connector in this run.
• Intended focused validation: pnpm --filter @zapengine/account-engine test -- test/unit/services/tenderly-simulation-sharing-error.spec.ts.
• Intended broader validation: pnpm --filter @zapengine/account-engine test -- test/unit/services/tenderly-simulation-fetch-error.spec.ts test/unit/services/tenderly-simulation-sharing-error.spec.ts, then GitHub CI.
• GitHub CI #617 is currently in progress.
• Vercel frontend / landing-page statuses are currently pending for the new head commit.

Auto-merge

• Not enabled: repository reports allow_auto_merge=false, and checks are not complete yet.

Next QA target

• If CI fails, fix [test-qa-hourly] Cover Tenderly simulation timeout #101 first.
• If CI passes and [test-qa-hourly] Cover Tenderly simulation timeout #101 merges, next good target is API route failure-path coverage around simulation/authorization boundaries.

[taiiiiiiiiiiii]

Test QA run summary

• Inspected open Test QA PR #101, repository settings, active diff, PR metadata, and GitHub Actions run #617.
• CI status: GitHub CI #617 completed successfully. Jobs checked: coverage, lint-test, deploy-gates, check-dead-env, verify-fly-docker; deploy-fly skipped as expected.
• QA change status: continued existing PR; no new commit pushed this run because #101 already contains the small coherent test-only improvement from the prior run.
• Diff scope: test-only, 2 files under apps/account-engine/test/unit/services/; no CI gates weakened, no docs/agent files changed, no secrets.
• Commands / validation: local commands not run because this automation run only has GitHub connector access. GitHub CI #617 is the source-of-truth validation and passed.
• Auto-merge: not enabled because repository settings report allow_auto_merge=false.
• Next QA target after merge: add API route failure-path coverage around malformed/unauthorized simulation requests or wallet transaction preparation boundaries.