Skip to content

Fix #390: make dialogs scrollable when viewport is constrained#742

Merged
Rigidity merged 1 commit into
xch-dev:mainfrom
joshpainter:fix/390-dialog-scroll-viewport
Feb 17, 2026
Merged

Fix #390: make dialogs scrollable when viewport is constrained#742
Rigidity merged 1 commit into
xch-dev:mainfrom
joshpainter:fix/390-dialog-scroll-viewport

Conversation

@joshpainter
Copy link
Copy Markdown
Contributor

Summary

  • iPad landscape + virtual keyboard covers the fee dialog
  • Added max-h-[85vh] overflow-y-auto to DialogContent
  • Only activates when content exceeds 85vh — no visual change on desktop

Changes

File Change
src/components/ui/dialog.tsx Add max-h-[85vh] overflow-y-auto to DialogContent

Test plan

  • Open a dialog on iPad landscape with virtual keyboard — content should scroll
  • Desktop dialogs should look unchanged (content doesn't exceed 85vh)
  • Test FeeOnlyDialog, TransferDialog, and AssignNftDialog with keyboard active

🤖 Generated with Claude Code

Add max-h-[85vh] overflow-y-auto to DialogContent so virtual keyboard
on iPad landscape no longer covers dialog content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joshpainter added a commit to joshpainter/sage that referenced this pull request Feb 12, 2026
Split batched PR xch-dev#740 into per-issue PRs:
- xch-dev#691 → PR xch-dev#741
- xch-dev#390 → PR xch-dev#742
- xch-dev#726 → PR xch-dev#743
- xch-dev#723 → PR xch-dev#744

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Rigidity Rigidity merged commit 0cd056e into xch-dev:main Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants