Fix 4 P1 bugs: #691, #390, #726, #723#740
Closed
joshpainter wants to merge 4 commits into
Closed
Conversation
MintGarden convention uses edition_total=0 to mean unlimited editions. Previously hidden because condition only checked > 1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add max-h-[85vh] overflow-y-auto to DialogContent so virtual keyboard on iPad landscape no longer covers dialog content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace cryptic BIP39 errors with user-friendly messages that identify the specific invalid word, wrong word count, or checksum failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevent crash when creating an offer with only requested assets and zero fee by adding validation on both backend and frontend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joshpainter
added a commit
to joshpainter/sage
that referenced
this pull request
Feb 11, 2026
Issues xch-dev#691, xch-dev#390, xch-dev#726, xch-dev#723 are now addressed in the bugfixes-p1 branch (PR xch-dev#740). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
bugbot run |
Collaborator
|
@cursor review |
Contributor
Author
|
Splitting into individual PRs — one per issue. |
joshpainter
added a commit
to joshpainter/sage
that referenced
this pull request
Feb 12, 2026
Split batched PR xch-dev#740 into per-issue PRs: - xch-dev#691 → PR xch-dev#741 - xch-dev#390 → PR xch-dev#742 - xch-dev#726 → PR xch-dev#743 - xch-dev#723 → PR xch-dev#744 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edition_total=0(MintGarden unlimited editions convention)Changes
src/components/NftCard.tsxtotal === 0, render ∞src/pages/Nft.tsxsrc/components/ui/dialog.tsxmax-h-[85vh] overflow-y-autoto DialogContentcrates/sage/src/error.rsInvalidMnemonic(String)variantcrates/sage/src/endpoints/keys.rssrc/pages/ImportWallet.tsxcrates/sage/src/endpoints/offers.rssrc/pages/MakeOffer.tsxTest plan
edition_total=0show "X of ∞" in card tooltip and detail pageedition_total > 1still show "X of Y" as beforecargo clippy --workspacepasses cleancargo check -p sagepasses clean🤖 Generated with Claude Code