Skip to content

fix(vite): reloading fails in non-browser environments#16368

Closed
keyding wants to merge 1 commit into
vitejs:mainfrom
keyding:patch/fix-in-chrome-ext
Closed

fix(vite): reloading fails in non-browser environments#16368
keyding wants to merge 1 commit into
vitejs:mainfrom
keyding:patch/fix-in-chrome-ext

Conversation

@keyding

@keyding keyding commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

After fixing the #16318 issue, there is a new issue that fails to reload when there is a modification in a non-browser environment (chrome extension's backgorund.js).

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red

Copy link
Copy Markdown
Member

This will cause errors in workers. It seems vite-plugin-web-extension modifies /@vite/client. I think it should be done there instead.

@keyding

keyding commented Apr 7, 2024

Copy link
Copy Markdown
Contributor Author

This will cause errors in workers. It seems vite-plugin-web-extension modifies /@vite/client. I think it should be done there instead.

Thanks for the reply, I think I know what to change.

@keyding keyding closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants