fix: do not access document in /@vite/client when not defined#16318
Merged
Conversation
|
|
7 tasks
sapphi-red
added
p3-minor-bug
sapphi-red
changed the title
/@vite/client when not defined
sapphi-red
previously approved these changes
Apr 3, 2024
sapphi-red
left a comment
sapphi-red
left a comment
Member
There was a problem hiding this comment.
I added a test and confirmed this fixes #16277
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on ✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, remix, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest |
patak-cat
reviewed
Apr 3, 2024
patak-cat
reviewed
Apr 3, 2024
patak-cat
approved these changes
Apr 3, 2024
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the vite-plugin-web-extension plugin for chrome extension development, the
backgroundrequestshttp:/ /localhost:5173/@vite/client,backgrounddoes not existdocument.