Skip to content

Format denis/configure.sh dump output to be friendlier #235

Merged
charliemirabile merged 2 commits into
masterfrom
configure_time
Feb 18, 2025
Merged

Format denis/configure.sh dump output to be friendlier #235
charliemirabile merged 2 commits into
masterfrom
configure_time

Conversation

@theyoyojo

@theyoyojo theyoyojo commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

New behavior:

joel@fedora:~/src/singularity$ ./denis/configure.sh dump
 --- Assignments ---
test1:
	Initial:	Monday, February 17, 2025 06:02:50 PM EST (-0500)
	Peer Review:	Monday, February 17, 2025 06:02:55 PM EST (-0500)
	Final:		Monday, February 17, 2025 06:03:00 PM EST (-0500)
joel@fedora:~/src/singularity$ ./denis/configure.sh dump -i
 --- Assignments ---
test1:
	Initial:	2025-02-17T18:02:50-05:00
	Peer Review:	2025-02-17T18:02:55-05:00
	Final:		2025-02-17T18:03:00-05:00
joel@fedora:~/src/singularity$ ./denis/configure.sh dump --iso
 --- Assignments ---
test1:
	Initial:	2025-02-17T18:02:50-05:00
	Peer Review:	2025-02-17T18:02:55-05:00
	Final:		2025-02-17T18:03:00-05:00

Fixes #231

@theyoyojo theyoyojo changed the title Configure time Format denis/configure.sh dump output to be friendlier Feb 17, 2025

@charliemirabile charliemirabile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, few nitpicks

Comment thread denis/configure.py Outdated
Comment thread denis/configure.py
Comment thread denis/configure.py Outdated
Signed-off-by: Joel Savitz <joel@underground.software>
…ption

Signed-off-by: Joel Savitz <joel@underground.software>

@charliemirabile charliemirabile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@charliemirabile charliemirabile merged commit 393fd72 into master Feb 18, 2025
@charliemirabile charliemirabile deleted the configure_time branch February 18, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

denis/configure.sh: dump: show dates as ISO format instead of unix timestamps

2 participants