Skip to content

topology2: pipelines: cavs: Add missing num_audio_formats for gains#5977

Closed
ujfalusi wants to merge 1 commit intothesofproject:mainfrom
ujfalusi:peter/pr/gain_format_fix_01
Closed

topology2: pipelines: cavs: Add missing num_audio_formats for gains#5977
ujfalusi wants to merge 1 commit intothesofproject:mainfrom
ujfalusi:peter/pr/gain_format_fix_01

Conversation

@ujfalusi
Copy link
Contributor

@ujfalusi ujfalusi commented Jul 1, 2022

Commit 773a05a ("topology2: add S24LE support") removed the default
1 from include/gain.conf but failed to add it to the pipeline config files.

This causes topology parsing error since the supported audio formats count
is invalid in these cases.

Signed-off-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com

Commit 773a05a ("topology2: add S24LE support") removed the default
1 from include/gain.conf but failed to add it to the pipeline config files.

This causes topology parsing error since the supported audio formats count
is invalid in these cases.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
@ujfalusi
Copy link
Contributor Author

ujfalusi commented Jul 1, 2022

@lgirdwood, this patch fixes the regression showing up since yesterday in CI's IPC4 daily tests.

snd_sof:sof_widget_ready: sof-audio-pci-intel-tgl 0000:00:1f.3: tplg: ready widget id 2 pipe 1 type 6 name : gain.1.1 stream none
sof-audio-pci-intel-tgl 0000:00:1f.3: Invalid audio format count for gain.1.1
sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 6 name : gain.1.1 stream none
skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: failed to load widget gain.1.1
skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: topology: could not load header: -22
sof-audio-pci-intel-tgl 0000:00:1f.3: error: tplg component load failed -22
sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to load DSP topology -22
sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22
skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: failed to instantiate card -22
skl_hda_dsp_generic: probe of skl_hda_dsp_generic failed with error -22

@ujfalusi
Copy link
Contributor Author

ujfalusi commented Jul 1, 2022

#5975 is created already by @aiChaoSONG, closing this as duplicate

@ujfalusi ujfalusi closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant