topology2: add missing num_audio_formats for gain#5975
Closed
aiChaoSONG wants to merge 1 commit intomainfrom
Closed
topology2: add missing num_audio_formats for gain#5975aiChaoSONG wants to merge 1 commit intomainfrom
aiChaoSONG wants to merge 1 commit intomainfrom
Conversation
The default class level num_audio_formats for gain is removed in 773a05a, which causes gain widget num_audio_formats parsing issue in the kernel for topology with below two pipelines: - dai-copier-gain-mixin-capture - host-copier-gain-mixin-playback This patch adds num_audio_formats for gain widget in above two pipelines. Signed-off-by: Chao Song <chao.song@linux.intel.com>
aiChaoSONG
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
Author
|
@ranj063 It is very flexible to write a topology, so each developer has his/her own flavor, can we make a list of basic principles or coding styles for topology? so we can avoid fix like this PR. |
Contributor
|
validated that this can make cavs-mixin-mixout-hda.tplg work on multiple HDA platforms |
lgirdwood
approved these changes
Jul 1, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Would be nice if the parser could count stuff like this ?
ujfalusi
approved these changes
Jul 1, 2022
Collaborator
Author
No, we have first to know how many formats are there, and then parse these formats. the array length has to be known first. |
Collaborator
Author
|
Duplicated with #5971, close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default class level num_audio_formats for gain is
removed in 773a05a,
which causes gain widget num_audio_formats parsing issue
in the kernel for topology with below two pipelines:
This patch adds num_audio_formats for gain widget in
above two pipelines.
Signed-off-by: Chao Song chao.song@linux.intel.com