Merged
Conversation
NickLarsenNZ
commented
Feb 5, 2025
28 tasks
sbernauer
requested changes
Feb 7, 2025
Member
sbernauer
left a comment
There was a problem hiding this comment.
Implementation LGTM, many thanks!
It would be great if you could please add some docs for the user. Maybe below https://docs.stackable.tech/home/stable/trino/#_supported_versions? Or put it somewhere else and link to it there.
IMHO it should contain a quick explanation that Trino switches it's S3 implementation and link to trinodb/trino#24878.
Also mention that users can roll back to the legacy using this and that configOverrides, however that it will be removed eventually.
Thanks!
Maleware
previously requested changes
Feb 10, 2025
Improve error message
Emit warning only if tls is disabled.
NickLarsenNZ
commented
Feb 25, 2025
This is not ideal as it prevents people trying whatever version they want, but we will defer this to a team decision later.
sbernauer
requested changes
Mar 11, 2025
Member
sbernauer
left a comment
There was a problem hiding this comment.
Thanks for updating the PR!
Only small things left
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/docker-images#999.
Definition of Done Checklist