Conversation
…late run up to stackabletech/operator-templating@9001281 Reference-to: stackabletech/operator-templating@9001281 (Fix pre-commit hook)
Techassi
approved these changes
Feb 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
* test(integration): Add Trino 469, update latest version * docs: Update trino version to 469 * feat: Add support for Trino 469 * test(unit): Update trino version used in tests * chore: regenerate Cargo.nix It was missed in #704 * chore: Update changelog * wip: native s3 initial cut * wip: more versiony stuff * wip: parse Trino version as u16 version from String * wip: remove comment and restore newline * feat: Replace 469 with 470 * test: Trino now requires TLS for S3 * chore: Search and replace Trino productVersions * chore: Rename trino_version to product_version for consistency * refactor: Change product_version in the jvm mod to u16 for consistency * chore: Improve note about native s3 support * chore: Update changelog * chore: Update changelog * chore: Add warning about upcoming requirement for TLS requirement for S3 connections Although it is technically possible to enable legacy S3 support in Trino 469, we have forced native s3 support since 469 so the warning is written that way. * refactor: Use ensure! instead of if not * chore: Bump stackable-operator for S3 region support * feat: Set the S3 region unless it will be auto-discovered * test(smoke): Override hive metastore memory limit due to OOMKilled Ideally this should be done by the hive-operator. * docs: Update supported versions * Apply suggestions from code review Improve error message * Apply suggestions from code review Emit warning only if tls is disabled. * test: Update comments about minio and OpenShift testing * test: Adjusted comments about minio and OpenShift testing * chore: Bump stackable-operator and use the updated s3 region struct * chore: Update changelog * test: Add smoke_aws test to show how to use Trino with AWS S3 buckets * chore: Make the operator fail for unsupported versions This is not ideal as it prevents people trying whatever version they want, but we will defer this to a team decision later. * chore: Undo resource overrides now that Hive resources have been increased * Apply suggestions from code review Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de> * chore: Update changelog --------- Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Autogenerated PR to update templated files since the last template run up to stackabletech/operator-templating@9001281.
Tip
Please update the change type as appropriate.
For example, if the change is breaking, add an
!after the change type:If you need to add subsequent commits to make the checks pass, change the type:
For more information, See Conventional Commits.