Skip to content

feature: Add possibility to run multiple iterations of Lighthouse audits (#35) - #36

Merged
soulgalore merged 1 commit into
sitespeedio:masterfrom
tengremlin:lh-iterations
Nov 16, 2019
Merged

feature: Add possibility to run multiple iterations of Lighthouse audits (#35)#36
soulgalore merged 1 commit into
sitespeedio:masterfrom
tengremlin:lh-iterations

Conversation

@tengremlin

Copy link
Copy Markdown
Contributor

No description provided.

@soulgalore

Copy link
Copy Markdown
Member

I didn't get around to look at this this weekend, sorry, I needed to push through the coming filmstrip functionality in Compare. @beenanner do you have any time the coming week to have a look?

@tengremlin

Copy link
Copy Markdown
Contributor Author

hi,
I haven't seen any activity regarding this, so is there any way I can help?

@ghost

ghost commented Nov 14, 2019

Copy link
Copy Markdown

@tengremlin @soulgalore hi!
Is there any way I can help? Would be awesome to have this feature merged!
Thanks! :)

@soulgalore

Copy link
Copy Markdown
Member

I'm travelling tomorrow and can maybe try it out then. But I'm a little reluctant since again at CDS there was some talk about that they will implement multiple runs in the future, but maybe we can fix so nothing needs to be fixed on our side at that time.

@soulgalore

Copy link
Copy Markdown
Member

@tengremlin sorry for being so slow on this one. Yes looks good. I would have preferred having the Lighthouse result inside of the sitespeed.io HTML as before but I guess its hard to fix. I'll merge ASAP and it will go out in the next release, probably next Friday.

@soulgalore
soulgalore merged commit 35555eb into sitespeedio:master Nov 16, 2019
@soulgalore

Copy link
Copy Markdown
Member

thank you @tengremlin !

@soulgalore

Copy link
Copy Markdown
Member

Hi @tengremlin any chance you have time to look at the #42 that introduced with this PR? The thing that now it fires away Lighthouse tests directly when the URL arrives, making us run multiple Lighthouse tests at the same time if you test multiple URLs.

@soulgalore

Copy link
Copy Markdown
Member

FYI: I've fixed it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants