Lighthouse fails on 11.3.0-plus1

[kmaqsudi]

11.3.0-plus1 fails with message about lighthouse. The only addional option i've added was
--plugins.add /lighthouse

[2019-11-25 19:31:26] ERROR: Lighthouse could not test https://www.example.com/path please create an upstream issue: https://github.com/GoogleChrome/lighthouse/issues/new?template=Bug_report.md Error: no known mark: lh:gather:afterPass:OptimizedImages
at Object.exports.stop (/lighthouse/node_modules/marky/lib/marky.cjs.js:76:13)
at Function.timeEnd (/lighthouse/node_modules/lighthouse-logger/index.js:128:11)
at Function.afterPass (/lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:407:11)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async Function.runPass (/lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:665:5)
at async Function.run (/lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:573:29)
at async Function._gatherArtifactsFromBrowser (/lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:215:23)
at async Function.run (/lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:81:21)
at async runLighthouse (/lighthouse/runAudit.js:33:19)
at async runAudit (/lighthouse/runAudit.js:61:19)
at async Object.processMessage (/lighthouse/index.js:148:22)

[soulgalore]

Can you give the full example so I can reproduce? When I tested it worked for me?

$ docker run --shm-size=1g --rm -v "$(pwd)":/sitespeed.io sitespeedio/sitespeed.io:11.3.0-plus1 https://www.sitespeed.io/ -n 1
Google Chrome 78.0.3904.87 
Mozilla Firefox 70.0
[2019-11-25 21:55:26] INFO: Versions OS: linux 4.14.131-linuxkit nodejs: v12.13.0 sitespeed.io: 11.3.0 browsertime: 7.2.2 coach: 4.2.0
[2019-11-25 21:55:28] INFO: Will run Lighthouse tests after Browsertime has finished
[2019-11-25 21:55:28] INFO: Sending url https://www.sitespeed.io/ to test on Page Speed Insights
[2019-11-25 21:55:28] INFO: Running tests using Chrome - 1 iteration(s)
[2019-11-25 21:55:30] INFO: Testing url https://www.sitespeed.io/ iteration 1
[2019-11-25 21:55:31] INFO: Got https://www.sitespeed.io/ analysed from Google Page Speed Insights
[2019-11-25 21:55:47] INFO: https://www.sitespeed.io/ 13 requests, backEndTime: 171ms, firstPaint: 693ms, firstVisualChange: 719ms, DOMContentLoaded: 738ms, Load: 770ms, speedIndex: 751, visualComplete85: 863ms, lastVisualChange: 899ms, rumSpeedIndex: 693
[2019-11-25 21:55:47] INFO: Start collecting Lighthouse result for https://www.sitespeed.io/ iteration 1
[2019-11-25 21:55:58] INFO: HTML stored in /sitespeed.io/sitespeed-result/www.sitespeed.io/2019-11-25-21-55-26

Hi! Can confirm that multi-URL lighthouse tests are not working

[2019-11-26 09:31:05] INFO: Start collecting Lighthouse result for https://www.sauto.cz iteration 1
[2019-11-26 09:31:05] INFO: Start collecting Lighthouse result for https://www.sauto.cz/inzerce/osobni iteration 1
[2019-11-26 09:31:05] INFO: Start collecting Lighthouse result for https://www.sauto.cz/detail-prodejce/aaa-auto/2 iteration 1
[2019-11-26 09:31:16] ERROR: Lighthouse could not test https://www.sauto.cz/detail-prodejce/aaa-auto/2 please create an upstream issue: https://github.com/GoogleChrome/lighthouse/issues/new?template=Bug_report.md Error: no known mark: lh:gather:loadBlank
    at Object.exports.stop (/usr/src/plugin-lighthouse/node_modules/marky/lib/marky.cjs.js:76:13)
    at Function.timeEnd (/usr/src/plugin-lighthouse/node_modules/lighthouse-logger/index.js:128:11)
    at Function.loadBlank (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:45:9)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Function.runPass (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:632:5)
    at async Function.run (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:573:29)
    at async Function._gatherArtifactsFromBrowser (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:215:23)
    at async Function.run (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:81:21)
    at async runLighthouse (/usr/src/plugin-lighthouse/runAudit.js:35:19)
    at async runAudit (/usr/src/plugin-lighthouse/runAudit.js:64:19)
    at async Object.processMessage (/usr/src/plugin-lighthouse/index.js:148:22)
[2019-11-26 09:31:16] ERROR: TypeError: Cannot read property 'lhr' of undefined
    at Object.processMessage (/usr/src/plugin-lighthouse/index.js:199:28)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
[2019-11-26 09:31:16] ERROR: Lighthouse could not test https://www.sauto.cz please create an upstream issue: https://github.com/GoogleChrome/lighthouse/issues/new?template=Bug_report.md Error: no known mark: lh:gather:afterPass:Accessibility
    at Object.exports.stop (/usr/src/plugin-lighthouse/node_modules/marky/lib/marky.cjs.js:76:13)
    at Function.timeEnd (/usr/src/plugin-lighthouse/node_modules/lighthouse-logger/index.js:128:11)
    at Function.afterPass (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:407:11)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Function.runPass (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:665:5)
    at async Function.run (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:573:29)
    at async Function._gatherArtifactsFromBrowser (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:215:23)
    at async Function.run (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:81:21)
    at async runLighthouse (/usr/src/plugin-lighthouse/runAudit.js:35:19)
    at async runAudit (/usr/src/plugin-lighthouse/runAudit.js:64:19)
    at async Object.processMessage (/usr/src/plugin-lighthouse/index.js:148:22)
[2019-11-26 09:31:16] ERROR: TypeError: Cannot read property 'lhr' of undefined
    at Object.processMessage (/usr/src/plugin-lighthouse/index.js:199:28)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Note that only 2 out of 3 runs are failing and that might be due to the fact that all test are starting simultaneously.

[kmaqsudi]

Yes. When I changed my script to run a single page, it passes with no issues.

[soulgalore]

Yeah this must have been introduced by #36

[soulgalore]

Yeah the problem is that it tries to fire away multiple tests at the same time.

[soulgalore]

I've just pushed 11.4.0 that fixes that, but please verify that it works for you. I've missed adding a test case for multiple URLs in Travis, sorry.

[kmaqsudi]

verifying now. should have an answer in 30 mins

…

On Tue, Nov 26, 2019 at 5:51 PM Peter Hedenskog ***@***.***> wrote: I've just pushed 11.4.0 that fixes that, but please verify that it works for you. I've missed adding a test case for multiple URLs in Travis, sorry. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#42?email_source=notifications&email_token=AAHZTSURGKSPBMO4YLGYTDDQVWR5TA5CNFSM4JRPJW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHWKNA#issuecomment-558851380>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHZTSQHTR3H2MN2N5ZITM3QVWR5TANCNFSM4JRPJW6A> .

-- /khalid#

[soulgalore]

I think this works now.