Skip to content

remove f16-math patch#1674

Merged
bjorn3 merged 1 commit into
rust-lang:mainfrom
folkertdev:remove-f16-math-patch
Jul 12, 2026
Merged

remove f16-math patch#1674
bjorn3 merged 1 commit into
rust-lang:mainfrom
folkertdev:remove-f16-math-patch

Conversation

@folkertdev

@folkertdev folkertdev commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

We now have fallbacks via f32 for the intrinsics in core since rust-lang/rust#150946.

cc rust-lang/rust#158972

@folkertdev folkertdev added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Jul 11, 2026
@rustbot

This comment has been minimized.

@folkertdev
folkertdev force-pushed the remove-f16-math-patch branch from 3492079 to 5f7b292 Compare July 11, 2026 19:33
@rustbot

This comment has been minimized.

@folkertdev folkertdev removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Jul 11, 2026
@bjorn3

bjorn3 commented Jul 11, 2026

Copy link
Copy Markdown
Member

Can 0001-portable-simd-Disable-f16-usage-in-portable-simd.patch be removed now too? And would you mind rebasing again? I had to change the libcall code to fix the abi for f128 on s390x.

 We now have fallbacks via f32 for the intrinsics in core
@folkertdev
folkertdev force-pushed the remove-f16-math-patch branch from 5f7b292 to e997dc7 Compare July 11, 2026 21:26
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@folkertdev

Copy link
Copy Markdown
Contributor Author

Just rebased

I believe 0001-portable-simd-Disable-f16-usage-in-portable-simd.patch is specifically needed on windows, and the issue it runs into is fixed in GCC 16 but our CI does not use that yet. I can try removing it in a separate PR though to clarify.

@bjorn3
bjorn3 merged commit 1ca1217 into rust-lang:main Jul 12, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants