remove f16-math patch#1674
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
remove-f16-math-patch
branch
from
July 11, 2026 19:33
3492079 to
5f7b292
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
Can 0001-portable-simd-Disable-f16-usage-in-portable-simd.patch be removed now too? And would you mind rebasing again? I had to change the libcall code to fix the abi for f128 on s390x. |
We now have fallbacks via f32 for the intrinsics in core
folkertdev
force-pushed
the
remove-f16-math-patch
branch
from
July 11, 2026 21:26
5f7b292 to
e997dc7
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Just rebased I believe |
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have fallbacks via f32 for the intrinsics in core since rust-lang/rust#150946.
cc rust-lang/rust#158972