cranelift: use f16 fallbacks#158972
Closed
folkertdev wants to merge 2 commits into
Closed
Conversation
rustbot
added
A-CI
folkertdev
force-pushed
the
cranelift-use-f16-fallbacks
branch
from
July 8, 2026 19:34
c24084d to
afcbb76
Compare
folkertdev
force-pushed
the
cranelift-use-f16-fallbacks
branch
from
July 10, 2026 07:45
afcbb76 to
219619d
Compare
Contributor
Author
|
@bjorn3 is it OK to merge this here or is it better to do it on the cg_clif repo? |
Member
|
I would prefer in the cg_clif repo for better CI coverage. |
bjorn3
reviewed
Jul 10, 2026
| sym::powif64 => ("__powidf2", 2, fx.tcx.types.f64, types::F64), // compiler-builtins | ||
| sym::powif128 => ("__powitf2", 2, fx.tcx.types.f128, types::F128), // compiler-builtins | ||
| sym::powf16 => ("powf16", 2, fx.tcx.types.f16, types::F16), | ||
|
|
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
This was deliberate, otherwise the "has a fallback via f32" is aligned with "compiler-builtins" from the preceding line, which looks really weird.
Member
There was a problem hiding this comment.
Maybe a newline between each family of intrinsics?
Contributor
Author
|
We'll handle this in rust-lang/rustc_codegen_cranelift#1674 |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocked on #150946
cc @bjorn3
cc rust-lang/rustc_codegen_cranelift#1622