Rollup of 15 pull requests#159278
Closed
JonathanBrouwer wants to merge 40 commits into
Closed
Conversation
Because that's what it is: any type with tokens must also have attrs. This simplifies some trait bounds.
This way codegen backends don't have to check for a magic symbol name prefix to detect LLVM intrinsic calls and thus can more easily handle them separately as necessary.
This optimisation is currently broken on s390x[^1]. It looks like a big-endian issue in general. but as we only know about the test fails on s390x we only disable it there. Should be reenabled when the problem is fixed and llvm backend is updated. [^1]: llvm/llvm-project#208712
This function's name is referring to `Step::make_run`, and has nothing to do with run-make tests.
This was a reminder to make the lint translatable, but the code to make lints translatable has since been removed
Comptime inherent impls A fairly trivial addition to comptime. Now that we have inherent methods that can individually be `#[rustc_comptime]`, we can just extend that to inherent impls. lots of new test coverage as the attribute (even if it errors due to being illegal there) affects how the items it's applied to behave. r? @fee1-dead
…, r=jdonszelmann rerun in original typing mode if we meet any opaques in post analysis When the rerun condition is `OpaqueInStorage` and typing mode is `PostAnalysis/Codegen`, we do rerun the evaluation in original typing mode. It's strange that we don't do the same when the rerun condition is `OpaqueInStorageOrAnyOpaqueHasInferAsHidden`. This fixes an ICE when building `cargo` with the next solver. r? @jdonszelmann cc @lcnr
…petrochenkov Make `HasTokens` a sub-trait of `HasAttrs`. Because that's what it is: any type with tokens must also have attrs. This simplifies some trait bounds. r? @petrochenkov
…RalfJung,folkertdev Introduce InstanceKind::LlvmIntrinsic This way codegen backends don't have to check for a magic symbol name prefix to detect LLVM intrinsic calls and thus can more easily handle them separately as necessary.
Rename ModDefId to ModId and use more Addresses some FIXMEs. The `ModDefId` was used pretty sparingly, and honestly I wondered if it should exist at all. After making these changes, I think the type is worth it. Most notably it is now used in `Visibility::Restricted`. I first renamed `ModDefId` to `ModId` since I think the former is over-specific, and also this is more in line with `BodyId` or `OwnerId`. I'll wait for initial feedback before fixing rustdoc/clippy.
rustbot
added
A-attributes
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Trying commit 7fc7316 with merge 4c9ad9c… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/29327199058 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 14, 2026
Rollup of 15 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #159197, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
rustbot
removed
the
S-waiting-on-author
Contributor
Author
|
@bors try cancel |
Contributor
|
Try build cancelled. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
HasTokensa sub-trait ofHasAttrs. #159160 (MakeHasTokensa sub-trait ofHasAttrs.)_instead of...as placeholder #159255 (Replace shortened type with_instead of...as placeholder)cannot relate bound region#144033)std_crates_for_run_maketostd_crates_for_make_run#159274 (bootstrap: Renamestd_crates_for_run_maketostd_crates_for_make_run)r? @ghost
Create a similar rollup