Comptime inherent impls#157824
Open
oli-obk wants to merge 3 commits into
Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
|
fee1-dead
reviewed
Jun 26, 2026
|
|
||
| pub(super) fn lower_constness(&mut self, c: Const) -> hir::Constness { | ||
| match c { | ||
| pub(super) fn lower_constness(&mut self, attrs: &[hir::Attribute], c: Const) -> hir::Constness { |
Member
There was a problem hiding this comment.
It might make sense to clarify in a comment here that ComptimeParser under compiler/rustc_attr_parsing/src/attributes/semantics.rs actually controls where a Comptime constness is actually allowed.
fee1-dead
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=fee1-dead |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 14, 2026
Comptime inherent impls A fairly trivial addition to comptime. Now that we have inherent methods that can individually be `#[rustc_comptime]`, we can just extend that to inherent impls. lots of new test coverage as the attribute (even if it errors due to being illegal there) affects how the items it's applied to behave. r? @fee1-dead
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 14, 2026
Comptime inherent impls A fairly trivial addition to comptime. Now that we have inherent methods that can individually be `#[rustc_comptime]`, we can just extend that to inherent impls. lots of new test coverage as the attribute (even if it errors due to being illegal there) affects how the items it's applied to behave. r? @fee1-dead
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 14, 2026
Comptime inherent impls A fairly trivial addition to comptime. Now that we have inherent methods that can individually be `#[rustc_comptime]`, we can just extend that to inherent impls. lots of new test coverage as the attribute (even if it errors due to being illegal there) affects how the items it's applied to behave. r? @fee1-dead
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 14, 2026
Comptime inherent impls A fairly trivial addition to comptime. Now that we have inherent methods that can individually be `#[rustc_comptime]`, we can just extend that to inherent impls. lots of new test coverage as the attribute (even if it errors due to being illegal there) affects how the items it's applied to behave. r? @fee1-dead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fairly trivial addition to comptime. Now that we have inherent methods that can individually be
#[rustc_comptime], we can just extend that to inherent impls.lots of new test coverage as the attribute (even if it errors due to being illegal there) affects how the items it's applied to behave.
r? @fee1-dead