Skip to content

compiletest: use VecDeque::pop_front_if#159124

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
kn1g78:fix/compiletest-pop-front-if
Jul 13, 2026
Merged

compiletest: use VecDeque::pop_front_if#159124
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
kn1g78:fix/compiletest-pop-front-if

Conversation

@kn1g78

@kn1g78 kn1g78 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

VecDeque::pop_front_if has been stable since Rust 1.93 and is now available to bootstrap.

Replace compiletest's local compatibility helper with the standard library method and remove the obsolete FIXME.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 11, 2026
@kn1g78 kn1g78 marked this pull request as ready for review July 11, 2026 12:00
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 11, 2026
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
  • @jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu, oli-obk

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 4daa033 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 12, 2026
…f, r=jieyouxu

compiletest: use VecDeque::pop_front_if

`VecDeque::pop_front_if` has been stable since Rust 1.93 and is now available to bootstrap.

Replace compiletest's local compatibility helper with the standard library method and remove the obsolete FIXME.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 12, 2026
…f, r=jieyouxu

compiletest: use VecDeque::pop_front_if

`VecDeque::pop_front_if` has been stable since Rust 1.93 and is now available to bootstrap.

Replace compiletest's local compatibility helper with the standard library method and remove the obsolete FIXME.
rust-bors Bot pushed a commit that referenced this pull request Jul 12, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module)
 - #159010 (Simplify the unwind crate)
 - #159131 (bootstrap: Allow path-based skipping of the coverage test suite)
 - #159134 (std: fix panic in Windows Stdin::read_vectored with pending surrogate)
 - #159178 (Print duration of BOLT instrumentation and optimization steps)
 - #159112 (Fix segfault in env access in statically linked FreeBSD binaries)
 - #159124 (compiletest: use VecDeque::pop_front_if)
rust-bors Bot pushed a commit that referenced this pull request Jul 12, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module)
 - #159131 (bootstrap: Allow path-based skipping of the coverage test suite)
 - #159134 (std: fix panic in Windows Stdin::read_vectored with pending surrogate)
 - #159178 (Print duration of BOLT instrumentation and optimization steps)
 - #159112 (Fix segfault in env access in statically linked FreeBSD binaries)
 - #159124 (compiletest: use VecDeque::pop_front_if)
@rust-bors rust-bors Bot merged commit 7f9a0ab into rust-lang:main Jul 13, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 13, 2026
rust-timer added a commit that referenced this pull request Jul 13, 2026
Rollup merge of #159124 - kn1g78:fix/compiletest-pop-front-if, r=jieyouxu

compiletest: use VecDeque::pop_front_if

`VecDeque::pop_front_if` has been stable since Rust 1.93 and is now available to bootstrap.

Replace compiletest's local compatibility helper with the standard library method and remove the obsolete FIXME.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants