Apply MCP 1003 and move diagnostics.rs into its own module by GuillaumeGomez · Pull Request #158732 · rust-lang/rust

GuillaumeGomez · 2026-07-03T13:08:12Z

View all comments

Part of #158699.

r? @JonathanBrouwer

rustbot · 2026-07-03T13:08:15Z

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-07-03T13:08:18Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

JonathanBrouwer · 2026-07-05T06:59:31Z

I don't think this is what the MCP said.
I think what we settled on is:

src/diagnostics.rs usually

src/diagnostics/mod.rs with src/diagnostics/impl.rs if there's a need for multiple files

View changes since the review

GuillaumeGomez · 2026-07-10T10:20:19Z

Finally made the only change for this PR before moving forward for the rest. :)

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-07-10T10:41:47Z

📌 Commit 2de1207 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

… r=JonathanBrouwer Apply MCP 1003 and move diagnostics.rs into its own module Fixes rust-lang#158699. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #157690 (codegen_ssa: pack small const aggregates into immediate stores) - #159005 (Use `as_lang_item` instead of repeatedly matching) - #156735 (Move NativeLib::filename to the rmeta-link archive member) - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158965 (Add codegen test for Result is_ok unwrap) - #159050 (assert only opaques with sub unified hidden infer are non-rigid)

@JonathanBrouwer

… r=JonathanBrouwer Apply MCP 1003 and move diagnostics.rs into its own module Fixes rust-lang#158699. r? @JonathanBrouwer

…uwer Rollup of 10 pull requests Successful merges: - #157690 (codegen_ssa: pack small const aggregates into immediate stores) - #157706 (Deny `todo!()` in tidy) - #159005 (Use `as_lang_item` instead of repeatedly matching) - #156735 (Move NativeLib::filename to the rmeta-link archive member) - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #158930 (Reorganize `tests/ui/issues` [20/N]) - #158965 (Add codegen test for Result is_ok unwrap) - #158979 (Reorganize `tests/ui/issues` [21/N]) - #159050 (assert only opaques with sub unified hidden infer are non-rigid) - #159062 (Remove unused WEAK_ONLY_LANG_ITEMS static) Failed merges: - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module)

@JonathanBrouwer

… r=JonathanBrouwer Apply MCP 1003 and move diagnostics.rs into its own module Fixes rust-lang#158699. r? @JonathanBrouwer

GuillaumeGomez · 2026-07-11T22:46:27Z

Fixed merge conflicts v3.

@bors r=JonathanBrouwer

rust-bors · 2026-07-11T22:46:29Z

📌 Commit 4716c85 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 3 pull requests Successful merges: - #159125 (`mut` restriction lowering) - #159154 (compiler: redescribe llvmlike_vector_align as rust_vector_align) - #159157 (Better comment the struct used by `{read,write}_unaligned`) Failed merges: - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module)

JonathanBrouwer · 2026-07-12T05:21:55Z

Has yet again failed to merge into the rollup
@bors p=1

… `error_helper.rs` into the `diagnostics` folder in `rustc_resolve`

rustbot · 2026-07-12T13:48:14Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

GuillaumeGomez · 2026-07-12T13:48:32Z

Fixed merge conflicts v4.

@bors r=JonathanBrouwer

rust-bors · 2026-07-12T13:48:35Z

📌 Commit 65ed52f has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

… r=JonathanBrouwer Apply MCP 1003 and move diagnostics.rs into its own module Part of rust-lang#158699. r? @JonathanBrouwer

@JonathanBrouwer

… r=JonathanBrouwer Apply MCP 1003 and move diagnostics.rs into its own module Part of rust-lang#158699. r? @JonathanBrouwer

…uwer Rollup of 7 pull requests Successful merges: - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module) - #159010 (Simplify the unwind crate) - #159131 (bootstrap: Allow path-based skipping of the coverage test suite) - #159134 (std: fix panic in Windows Stdin::read_vectored with pending surrogate) - #159178 (Print duration of BOLT instrumentation and optimization steps) - #159112 (Fix segfault in env access in statically linked FreeBSD binaries) - #159124 (compiletest: use VecDeque::pop_front_if)

@JonathanBrouwer

… r=JonathanBrouwer Apply MCP 1003 and move diagnostics.rs into its own module Part of rust-lang#158699. r? @JonathanBrouwer

…uwer Rollup of 6 pull requests Successful merges: - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module) - #159131 (bootstrap: Allow path-based skipping of the coverage test suite) - #159134 (std: fix panic in Windows Stdin::read_vectored with pending surrogate) - #159178 (Print duration of BOLT instrumentation and optimization steps) - #159112 (Fix segfault in env access in statically linked FreeBSD binaries) - #159124 (compiletest: use VecDeque::pop_front_if)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2026

rustbot assigned JonathanBrouwer Jul 3, 2026

petrochenkov reviewed Jul 3, 2026

View reviewed changes

Comment thread compiler/rustc_resolve/src/diagnostics/impls.rs

Comment thread compiler/rustc_resolve/src/late/diagnostics.rs

GuillaumeGomez force-pushed the rename-diagnostics branch from b8a763f to 6942310 Compare July 3, 2026 13:49

JonathanBrouwer reviewed Jul 5, 2026

View reviewed changes

JonathanBrouwer requested changes Jul 5, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2026

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the rename-diagnostics branch from 6942310 to 2de1207 Compare July 10, 2026 10:19

This comment has been minimized.

Sign in to view

JonathanBrouwer approved these changes Jul 10, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2026

JonathanBrouwer mentioned this pull request Jul 10, 2026

Rollup of 7 pull requests #159068

Closed

This was referenced Jul 10, 2026

Rollup of 10 pull requests #159077

Closed

Rollup of 10 pull requests #159080

Closed

JonathanBrouwer mentioned this pull request Jul 10, 2026

Rollup of 12 pull requests #159095

Closed

GuillaumeGomez mentioned this pull request Jul 10, 2026

Apply MCP 1003 and move diagnostics.rs into its own module - part 2 #159096

Closed

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 11, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 11, 2026

GuillaumeGomez force-pushed the rename-diagnostics branch from 63c6888 to 4716c85 Compare July 11, 2026 22:46

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 11, 2026

jhpratt mentioned this pull request Jul 12, 2026

Rollup of 3 pull requests #159166

Merged

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 12, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 12, 2026

Apply MCP 1003 and move diagnostics.rs into its own module and move…

65ed52f

… `error_helper.rs` into the `diagnostics` folder in `rustc_resolve`

GuillaumeGomez force-pushed the rename-diagnostics branch from 4716c85 to 65ed52f Compare July 12, 2026 13:48

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 12, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 12, 2026

Rollup merge of rust-lang#158732 - GuillaumeGomez:rename-diagnostics,…

27694db

… r=JonathanBrouwer Apply MCP 1003 and move diagnostics.rs into its own module Part of rust-lang#158699. r? @JonathanBrouwer

jhpratt mentioned this pull request Jul 12, 2026

Rollup of 5 pull requests #159180

Closed

JonathanBrouwer mentioned this pull request Jul 12, 2026

Rollup of 7 pull requests #159187

Closed

JonathanBrouwer mentioned this pull request Jul 12, 2026

Rollup of 6 pull requests #159192

Open

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Jul 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 3, 2026

Uh oh!

rustbot commented Jul 3, 2026

Uh oh!

Uh oh!

Uh oh!

JonathanBrouwer Jul 5, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Jul 10, 2026

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jul 10, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Jul 11, 2026

Uh oh!

rust-bors Bot commented Jul 11, 2026

Uh oh!

JonathanBrouwer commented Jul 12, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jul 12, 2026

Uh oh!

GuillaumeGomez commented Jul 12, 2026

Uh oh!

rust-bors Bot commented Jul 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GuillaumeGomez commented Jul 3, 2026 •

edited by rustbot

Loading

JonathanBrouwer Jul 5, 2026 •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading