Fix unused variable warnings for diverging expressions by chenyukang · Pull Request #158846 · rust-lang/rust

chenyukang · 2026-07-06T08:30:34Z

rustbot · 2026-07-06T08:30:38Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

rustbot · 2026-07-06T08:30:41Z

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 20 candidates

tiif · 2026-07-13T08:16:33Z

r? me

tiif

Thanks for fixing this! Just two more nits, then r=me after green CI.

View changes since this review

TaKO8Ki

r=me after addressing suggesitons from tiif

View changes since this review

chenyukang · 2026-07-13T13:49:33Z

@bors retry

rust-bors · 2026-07-13T13:49:36Z

❗ You can only retry pull requests that are approved and have a previously failed auto build.

rustbot · 2026-07-13T14:42:51Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

chenyukang · 2026-07-13T15:59:36Z

@bors r=TaKO8Ki,tiif

rust-bors · 2026-07-13T15:59:44Z

📌 Commit d61f033 has been approved by TaKO8Ki,tiif

It is now in the queue for this repository.

…d-never-binding, r=TaKO8Ki,tiif Fix unused variable warnings for diverging expressions Fixes rust-lang#158783

…uwer Rollup of 14 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

…d-never-binding, r=TaKO8Ki,tiif Fix unused variable warnings for diverging expressions Fixes rust-lang#158783

…uwer Rollup of 15 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #156047 (Fix trait method resolution on an adjusted never type) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158804 (Clarify `as_uninit_mut` may point to uninitialized memory) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

JonathanBrouwer · 2026-07-13T18:15:09Z

@bors try jobs=x86_64-gnu-llvm-22-3

…ding, r=<try> Fix unused variable warnings for diverging expressions try-job: x86_64-gnu-llvm-22-3

…uwer Rollup of 13 pull requests Successful merges: - #157706 (Deny `todo!()` in tidy) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158804 (Clarify `as_uninit_mut` may point to uninitialized memory) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

rust-bors · 2026-07-13T20:15:32Z

☀️ Try build successful (CI)
Build commit: 744eb67 (744eb67d2e962d6a713b5044f135d3ef28b247a7)
Base parent: 225e91c (225e91c03da22cd4b9792b83c1cfc97967101614)

Rollup merge of #158846 - chenyukang:yukang-fix-158783-unused-never-binding, r=TaKO8Ki,tiif Fix unused variable warnings for diverging expressions Fixes #158783

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2026

rustbot assigned TaKO8Ki Jul 6, 2026

This comment has been minimized.

Sign in to view

chenyukang force-pushed the yukang-fix-158783-unused-never-binding branch from d838658 to 4216015 Compare July 6, 2026 13:05

tiif reviewed Jul 9, 2026

View reviewed changes

Comment thread library/core/src/keyword_docs.rs

rustbot assigned tiif and unassigned TaKO8Ki Jul 13, 2026

tiif reviewed Jul 13, 2026

View reviewed changes

Comment thread compiler/rustc_mir_transform/src/liveness.rs

Comment thread compiler/rustc_mir_transform/src/liveness.rs

Comment thread library/core/src/keyword_docs.rs

TaKO8Ki reviewed Jul 13, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

chenyukang force-pushed the yukang-fix-158783-unused-never-binding branch from f231d58 to d561696 Compare July 13, 2026 13:11

Fix unused variable warnings for diverging expressions

d61f033

chenyukang force-pushed the yukang-fix-158783-unused-never-binding branch from d561696 to d61f033 Compare July 13, 2026 14:42

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2026

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 14 pull requests #159236

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 15 pull requests #159240

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 13, 2026

Auto merge of #158846 - chenyukang:yukang-fix-158783-unused-never-bin…

744eb67

…ding, r=<try> Fix unused variable warnings for diverging expressions try-job: x86_64-gnu-llvm-22-3

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 13 pull requests #159246

Merged

rust-bors Bot merged commit a1855a2 into rust-lang:main Jul 13, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 13, 2026

rust-timer added a commit that referenced this pull request Jul 13, 2026

Unrolled build for #158846

5851582

Rollup merge of #158846 - chenyukang:yukang-fix-158783-unused-never-binding, r=TaKO8Ki,tiif Fix unused variable warnings for diverging expressions Fixes #158783

Uh oh!

Uh oh!

Conversation

chenyukang commented Jul 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

This comment has been minimized.

Uh oh!

tiif commented Jul 13, 2026

Uh oh!

tiif left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TaKO8Ki left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

chenyukang commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

rustbot commented Jul 13, 2026

Uh oh!

chenyukang commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

JonathanBrouwer commented Jul 13, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chenyukang commented Jul 6, 2026 •

edited by rustbot

Loading

tiif left a comment •

edited

Loading

TaKO8Ki left a comment •

edited by rustbot

Loading