First steps of late-bound turbofishing (place FnDef behind a dummy binder) by addiesh · Pull Request #158632 · rust-lang/rust

addiesh · 2026-06-30T23:56:00Z

r? oli-obk

This PR is part of #156581. This should be functionally identical to prior behavior, with the added fact that FnDef now places its arguments behind a binder.

most changes boil down to

replacing args from FnDef with args.no_bound_vars().unwrap()
replacing Ty::new_fn_def(/* ... */, args) with Ty::new_fn_def(/* ... */, ty::Binder::dummy(args))

rustbot · 2026-06-30T23:56:06Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

addiesh · 2026-07-01T00:04:15Z

this change has nothing to do with LLVM and as such should probably not have A-LLVM

View changes since the review

addiesh · 2026-07-01T00:06:00Z

this PR probably shouldn't have as many tags as it does (A-LLVM, PG-exploit-mitigations, T-clippy, WG-trait-system-refactor)

addiesh · 2026-07-01T00:06:35Z

@rustbot review

rustbot · 2026-07-01T00:15:06Z

boxyUwU is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-07-01T16:49:51Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

rustbot · 2026-07-06T14:50:15Z

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to constck

cc @fee1-dead

changes to the core type system

cc @lcnr

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

Some changes occurred in match checking

cc @Nadrieril

HIR ty lowering was modified

cc @fmease

Some changes occurred in match lowering

cc @Nadrieril

addiesh · 2026-07-10T02:16:02Z

i think that should do it?
@rustbot ready

oli-obk · 2026-07-10T08:36:56Z

Needs a rebase

rustbot · 2026-07-10T15:08:25Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

oli-obk · 2026-07-10T18:08:58Z

And a properly named commit message 😅

oli-obk · 2026-07-13T14:19:31Z

@bors r+

rust-bors · 2026-07-13T14:19:35Z

📌 Commit 8fb83ab has been approved by oli-obk

It is now in the queue for this repository.

First steps of late-bound turbofishing (place FnDef behind a dummy binder) r? oli-obk This PR is part of rust-lang#156581. This should be functionally identical to prior behavior, with the added fact that FnDef now places its arguments behind a binder. most changes boil down to - replacing `args` from `FnDef` with `args.no_bound_vars().unwrap()` - replacing `Ty::new_fn_def(/* ... */, args)` with `Ty::new_fn_def(/* ... */, ty::Binder::dummy(args))`

…uwer Rollup of 13 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #156712 (Pointer authentication config and user facing options) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

First steps of late-bound turbofishing (place FnDef behind a dummy binder) r? oli-obk This PR is part of rust-lang#156581. This should be functionally identical to prior behavior, with the added fact that FnDef now places its arguments behind a binder. most changes boil down to - replacing `args` from `FnDef` with `args.no_bound_vars().unwrap()` - replacing `Ty::new_fn_def(/* ... */, args)` with `Ty::new_fn_def(/* ... */, ty::Binder::dummy(args))`

…uwer Rollup of 14 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

First steps of late-bound turbofishing (place FnDef behind a dummy binder) r? oli-obk This PR is part of rust-lang#156581. This should be functionally identical to prior behavior, with the added fact that FnDef now places its arguments behind a binder. most changes boil down to - replacing `args` from `FnDef` with `args.no_bound_vars().unwrap()` - replacing `Ty::new_fn_def(/* ... */, args)` with `Ty::new_fn_def(/* ... */, ty::Binder::dummy(args))`

…uwer Rollup of 15 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #156047 (Fix trait method resolution on an adjusted never type) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158804 (Clarify `as_uninit_mut` may point to uninitialized memory) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

…uwer Rollup of 13 pull requests Successful merges: - #157706 (Deny `todo!()` in tidy) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158804 (Clarify `as_uninit_mut` may point to uninitialized memory) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

Rollup merge of #158632 - addiesh:superfisher, r=oli-obk First steps of late-bound turbofishing (place FnDef behind a dummy binder) r? oli-obk This PR is part of #156581. This should be functionally identical to prior behavior, with the added fact that FnDef now places its arguments behind a binder. most changes boil down to - replacing `args` from `FnDef` with `args.no_bound_vars().unwrap()` - replacing `Ty::new_fn_def(/* ... */, args)` with `Ty::new_fn_def(/* ... */, ty::Binder::dummy(args))`

rustbot assigned oli-obk Jun 30, 2026

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Jun 30, 2026

addiesh mentioned this pull request Jun 30, 2026

Tracking Issue for early/late bound parameter cleanup and late-bound turbofishing #156581

Open

12 tasks

addiesh commented Jul 1, 2026

View reviewed changes

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2026

rustbot assigned BoxyUwU and unassigned oli-obk Jul 1, 2026

This comment has been minimized.

Sign in to view

BoxyUwU assigned oli-obk Jul 1, 2026

This comment has been minimized.

Sign in to view

addiesh force-pushed the superfisher branch 4 times, most recently from aba7ff3 to 403a9d1 Compare July 2, 2026 18:27

addiesh commented Jul 2, 2026

View reviewed changes

Comment thread compiler/rustc_type_ir/src/visit.rs

addiesh force-pushed the superfisher branch from 403a9d1 to d32832a Compare July 6, 2026 14:35

addiesh marked this pull request as ready for review July 6, 2026 14:50

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2026

This comment has been minimized.

Sign in to view

addiesh force-pushed the superfisher branch from 0c3925d to aaf4d4d Compare July 10, 2026 07:58

This comment has been minimized.

Sign in to view

addiesh force-pushed the superfisher branch from aaf4d4d to a374dc5 Compare July 10, 2026 15:08

place FnDef behind a binder, instantiate w/ Dummy

8fb83ab

addiesh force-pushed the superfisher branch from a374dc5 to 8fb83ab Compare July 10, 2026 18:53

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2026

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 13 pull requests #159231

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 14 pull requests #159236

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 15 pull requests #159240

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 13 pull requests #159246

Merged

rust-bors Bot merged commit 3bb66d7 into rust-lang:main Jul 13, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 13, 2026

Uh oh!

Uh oh!

Conversation

addiesh commented Jun 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 30, 2026

Uh oh!

addiesh Jul 1, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

addiesh commented Jul 1, 2026

Uh oh!

addiesh commented Jul 1, 2026

Uh oh!

rustbot commented Jul 1, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Jul 1, 2026

Uh oh!

This comment has been minimized.

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

addiesh commented Jul 10, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

oli-obk commented Jul 10, 2026

Uh oh!

rustbot commented Jul 10, 2026

Uh oh!

oli-obk commented Jul 10, 2026

Uh oh!

oli-obk commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

addiesh commented Jun 30, 2026 •

edited by rustbot

Loading

addiesh Jul 1, 2026 •

edited by rustbot

Loading