Skip to content

Fix rustc --unpretty=expanded emit of [const] [unsafe] impl Trait for#158600

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Arnavion:unpretty-const-impl-trait-keyword-order
Jun 30, 2026
Merged

Fix rustc --unpretty=expanded emit of [const] [unsafe] impl Trait for#158600
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Arnavion:unpretty-const-impl-trait-keyword-order

Conversation

@Arnavion

@Arnavion Arnavion commented Jun 30, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes #158599

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2026
@rustbot

rustbot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @JonathanBrouwer (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@rustbot

This comment has been minimized.

Sign in to view
@Arnavion Arnavion force-pushed the unpretty-const-impl-trait-keyword-order branch from 055c827 to 121f01b Compare June 30, 2026 04:32
@Arnavion

Arnavion commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

FYI this is my first contribution to this repo. I've done x build library and x test per https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html , and used the stage1 rustc to test the repro in the linked issue as well as my real code that triggered this.

@chenyukang

chenyukang commented Jun 30, 2026

Copy link
Copy Markdown
Member

Thanks!
@bors r=chenyukang

@rust-bors

rust-bors Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 121f01b has been approved by chenyukang

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 30, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of #158610 - JonathanBrouwer:rollup-YAPZ5ee, r=JonathanBro…
f5dca5d 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`)
 - #158560 (Move per-function debuginfo methods from codegen to builder methods)
 - #158563 (Test(lib/net): Fix `hostname_smoketest` for Win7)
 - #158571 (Update books)
 - #158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
rust-bors Bot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of #158610 - JonathanBrouwer:rollup-YAPZ5ee, r=JonathanBro…
f46ec52 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`)
 - #158560 (Move per-function debuginfo methods from codegen to builder methods)
 - #158563 (Test(lib/net): Fix `hostname_smoketest` for Win7)
 - #158571 (Update books)
 - #158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
@rust-bors rust-bors Bot merged commit 13316ff into rust-lang:main Jun 30, 2026
13 checks passed
rust-timer added a commit that referenced this pull request Jun 30, 2026
@rust-timer
Unrolled build for #158600
aae7ec0 
Rollup merge of #158600 - Arnavion:unpretty-const-impl-trait-keyword-order, r=chenyukang

Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`

Fixes #158599
@rustbot rustbot added this to the 1.98.0 milestone Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

rustfmt chokes on "impl const Trait" output by rustc --unpretty=expanded

4 participants

@Arnavion @rustbot @chenyukang @JonathanBrouwer