tests: only run lexical-scope-in-match.rs for LLDB >= 21#158592
Merged
rust-bors[bot] merged 1 commit intoJun 30, 2026
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Many other debuginfo tests fail on dev-desktops/lldb 18: https://gist.github.com/aDotInTheVoid/89af1178703593ca2f0b225f77a5d758 |
Member
Author
|
For now I suggest skipping the test suite entirely for local dev. I will discuss with compiler team what to do about the test suite while it is being reworked. |
Member
|
r=me (not sure CI matters, but let's wait for it) r? me |
Member
Author
|
I'll merge this for now but I'll need to look into a broader approach for the entire test suite |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`) - #158560 (Move per-function debuginfo methods from codegen to builder methods) - #158563 (Test(lib/net): Fix `hostname_smoketest` for Win7) - #158571 (Update books) - #158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`) - #158560 (Move per-function debuginfo methods from codegen to builder methods) - #158563 (Test(lib/net): Fix `hostname_smoketest` for Win7) - #158571 (Update books) - #158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
rust-timer
added a commit
that referenced
this pull request
Jun 30, 2026
Rollup merge of #158592 - jieyouxu:jieyouxu/misc/debuginfo-lldb, r=Mark-Simulacrum tests: only run `lexical-scope-in-match.rs` for LLDB >= 21 Dev Desktops currently run on an Ubuntu which has an older LLDB (e.g. LLDB 18), where this debuginfo test fails. Run this test only on LLDB >= 21. This passes for me locally with Apple/Swift-variant LLDB 21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Desktops currently run on an Ubuntu which has an older LLDB (e.g. LLDB 18), where this debuginfo test fails.
Run this test only on LLDB >= 21. This passes for me locally with Apple/Swift-variant LLDB 21.