Feed cleanups#156019
Open
nnethercote wants to merge 2 commits intorust-lang:mainfrom
Open
Conversation
RFC 430 says type parameters should be named "concise UpperCamelCase, usually single uppercase letter". So either `Key` or `K` is more appropriate than `KEY`, which looks like a constant. I chose `K` because it's a well-known abbreviation of "key" used in lots of places, e.g. `HashMap<K, V>`.
rustbot
added
S-waiting-on-review
oli-obk
approved these changes
May 1, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 1, 2026
Feed cleanups Two minor improvements. Details in the individual commits. r? @oli-obk
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
May 1, 2026
Feed cleanups Two minor improvements. Details in the individual commits. r? @oli-obk
rust-bors Bot
pushed a commit
that referenced
this pull request
May 1, 2026
Rollup of 6 pull requests Successful merges: - #149637 (Do not run jump-threading for GPUs) - #155948 (Fix order-dependent visibility diagnostics) - #155600 (Adds a couple UI tests for polonius) - #155995 (-Zembed-source: also embed external source) - #156019 (Feed cleanups) - #156031 (Return a single diagnostic from `lex_token_trees`.)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 1, 2026
Feed cleanups Two minor improvements. Details in the individual commits. r? @oli-obk
rust-bors Bot
pushed a commit
that referenced
this pull request
May 1, 2026
…uwer Rollup of 9 pull requests Successful merges: - #149637 (Do not run jump-threading for GPUs) - #154971 (Verify that penultimate segment of enum variant path refers to enum if it has args) - #155186 (Avoid loop_match self-assignment in MIR lowering) - #155948 (Fix order-dependent visibility diagnostics) - #156001 (ssa-range-prop: fix ICE when encountering self-domiating bb) - #155600 (Adds a couple UI tests for polonius) - #155995 (-Zembed-source: also embed external source) - #156019 (Feed cleanups) - #156031 (Return a single diagnostic from `lex_token_trees`.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor improvements. Details in the individual commits.
r? @oli-obk