ssa-range-prop: fix ICE when encountering self-domiating bb#156001
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom May 1, 2026
Merged
ssa-range-prop: fix ICE when encountering self-domiating bb#156001rust-bors[bot] merged 2 commits intorust-lang:mainfrom
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
dianqk
reviewed
Apr 30, 2026
| /// e.g. small loops like in `a` | ||
|
|
||
| //@ compile-flags: -Copt-level=2 | ||
| //@ check-pass |
Member
There was a problem hiding this comment.
Suggested change
| //@ check-pass | |
| //@ build-pass |
Human9000-bit
force-pushed
the
ssa-range-prop-155836
branch
from
702e0b7 to
80c5d47
Compare
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
lqd
reviewed
May 1, 2026
It used to ICE when hitting an `assert_ne!(location.block, successor.block` due to hitting a self-dominating bb Fixed by checking *strict* domination instead of normal one
Human9000-bit
force-pushed
the
ssa-range-prop-155836
branch
from
80c5d47 to
d3d6c12
Compare
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. |
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
May 1, 2026
…uwer Rollup of 9 pull requests Successful merges: - #149637 (Do not run jump-threading for GPUs) - #154971 (Verify that penultimate segment of enum variant path refers to enum if it has args) - #155186 (Avoid loop_match self-assignment in MIR lowering) - #155948 (Fix order-dependent visibility diagnostics) - #156001 (ssa-range-prop: fix ICE when encountering self-domiating bb) - #155600 (Adds a couple UI tests for polonius) - #155995 (-Zembed-source: also embed external source) - #156019 (Feed cleanups) - #156031 (Return a single diagnostic from `lex_token_trees`.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strictly_dominatesmethodFixes #155836
r? dianqk