Rollup of 9 pull requests by jhpratt · Pull Request #155506 · rust-lang/rust

jhpratt · 2026-04-19T03:56:32Z

Successful merges:

Add regression test for dead code elimination with drop + panic #155370 (Add regression test for dead code elimination with drop + panic)
Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser #154823 (Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser)
Implement core::arch::return_address and tests #154972 (Implement core::arch::return_address and tests)
Add test for coalescing of diagnostic attribute duplicates #155294 (Add test for coalescing of diagnostic attribute duplicates)
triagebot.toml: Sync assign.owners with autolabel."T-compiler" #155352 (triagebot.toml: Sync assign.owners with autolabel."T-compiler")
Add temporary scope to assert_matches #155431 (Add temporary scope to assert_matches)
ACP Implementation of PermissionsExt for Windows #152995 (ACP Implementation of PermissionsExt for Windows )
deprecate std::char constants and functions #153873 (deprecate std::char constants and functions)
libtest: use binary search for --exact test filtering #154865 (libtest: use binary search for --exact test filtering)

similar to how constants in those modules for numeric types have been deprecated

The test array is sorted by name at compile time. When `--exact` is passed in, use binary search for O(f log n) lookups instead of an O(n) linear scan, under the assumption that f << n (which is true for the most relevant cases). This is important for Miri, where the interpreted execution makes the linear scan very expensive. I measured this against a repo with 1000 empty tests, running `cargo +stage1 miri nextest run test_00` (100 tests) under hyperfine: * Before (linear scan): 49.7s ± 0.6s * After (binary search): 41.9s ± 0.2s (-15.7%) I also tried a few other variations (particularly swapping matching tests to the front of the list + truncating the list), but the index + swap_remove approach proved to be the fastest. Questions: - [ ] To be conservative, I've assumed that test_main can potentially receive an unsorted list of tests. Is this assumption correct?

…tilities to observe, set, and create a Permissions struct with certain file attributes

…parser The spdx-rs crate is no longer maintained and is behind on its own dependency updates. The only function that collect-license-metadata uses from it is `spdx_rs::parsers::spdx_from_tag_value`, which parses the output of the `reuse` tool to extract file names, licences and copyright text. Replace this with a small minimal parser that handles just the subset of the SPDX tag-value format that is needed: `Tag: Value` line pairs and multi-line `<text>...</text>` blocks. Coincidentally, this gets rid of the last transitive dependency on syn v1.

In `autolabel."T-compiler"`, several `./tests/*` dirs are listed. But many of them are missing from `assign.owners`. Add them all to `assign.owners` so reviewers are picked from the compiler group, and not from the small `assign.adhoc_groups.fallback` group.

Dead code elimination used to fail when a Drop impl contained a panic and a potentially-panicking external function was called after the value was created. This was fixed since 1.82 but no regression test was added. The test verifies that foo() compiles to just a call to unknown() and ret void, with no panic or panicking call in the function body. Signed-off-by: Naveen R. Iyer <iyernaveenr@gmail.com>

Addresses rust-lang#154406 in part. assert_eq will be done in a separate PR.

Fix typo Apply suggestions from code review Wording/docs changes. Co-authored-by: Ralf Jung <post@ralfj.de> Change signature according to Ralf's comment Fix call to `core::intrinsics::return_address()` according to the new signature Add cranelift implementation for intrinsic Change wording on `return_address!()` to be clear that returning a null pointer is best-effort. Fix formatting of doc comment Fix mistake in cranelift codegen

…4532-needs-test, r=Mark-Simulacrum Add regression test for dead code elimination with drop + panic Add a codegen test for rust-lang#114532. The bug was that dead code elimination failed when a `Drop` impl contained a `panic!` and a potentially-panicking external function was called after the value was created. This was fixed since 1.82 but no regression test was added. The test verifies that `foo()` compiles to just a call to `unknown()` + `ret void`, with no panic or panicking call in the function body. Closes rust-lang#114532

…Mark-Simulacrum Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser The spdx-rs crate [is no longer maintained](https://github.com/doubleopen-project/spdx-rs/pulls) and is behind on its own dependency updates. It is currently used in [the collect-license-metadata tool](https://github.com/rust-lang/rust/tree/main/src/tools/collect-license-metadata), employing a single function therefrom: `spdx_rs::parsers::spdx_from_tag_value`, which parses the output of the `reuse` tool to extract file names, licences and copyright text. This PR replaces the use of said function with a small minimal parser that handles just the subset of the SPDX tag-value format that is needed: `Tag: Value` line pairs and multi-line `<text>...</text>` blocks. Coincidentally, this gets rid of the last transitive dependency on syn v1.

…-Simulacrum Implement `core::arch::return_address` and tests Tracking issue: rust-lang#154966 Implements libs-team#768

Add test for coalescing of diagnostic attribute duplicates There is an existing [test](github.com/rust-lang/rust/blob/main/tests/ui/diagnostic_namespace/on_unimplemented/report_warning_on_duplicated_options.rs) that warnings for duplicates are emitted, but not for the messages themselves.

@Mark-Simulacrum

triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"` In `autolabel."T-compiler"`, several `./tests/*` dirs are listed. But many of them are missing from `assign.owners`. Add them all to `assign.owners` so reviewers are picked from the compiler group, and not from the small `assign.adhoc_groups.fallback` group. Discovered in rust-lang#153941 (comment). CC fallback group @Mark-Simulacrum @jieyouxu who can maybe confirm that the old setup was not intentional? (Edit: I hope it was not intentional, because in that case I should have reached out to you personally beforehand.)

…-matches, r=Amanieu Add temporary scope to assert_matches Addresses rust-lang#154406 in part. `assert_eq` will be done in a separate PR.

@ChrisDenton

… r=Mark-Simulacrum ACP Implementation of PermissionsExt for Windows This PR implements the `PermissionsExt` for Windows ACP and adds file attribute methods in `FilePermissions` struct (to be decided whether we use them or not). See this [tracking issue](rust-lang#152956 (comment)) for further detail and links. I also added some comments in the code for clarifications about the ACP (e.g. whether we should have a `set_file_attributes()` + `from_file_attributes()` method to mirror what unix's `PermissionsExt` is doing). Also, some relevant links on this: * [File Attribute Constants](https://learn.microsoft.com/en-us/windows/win32/fileio/file-attribute-constants) * [`attrib` command](https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/attrib) * [SetFileAttributesA](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-setfileattributesa) * [GetFileAttributesA](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfileattributesa) * [Window's File Attributes Column Values](https://superuser.com/questions/44812/windows-explorers-file-attribute-column-values) * [What is the 'M' attribute in Windows file system for?](https://superuser.com/questions/1621649/what-is-the-m-attribute-in-windows-file-system-for) Note: Apologies for the multiple forced push. I haven't set up my Windows VM up yet to compile and check the code, so I've been using the CI to help me with that. r? @ChrisDenton

…ark-Simulacrum deprecate `std::char` constants and functions similar to how constants in those modules for numeric types have been deprecated. The `std::char` module contains: Three stable constants that this PR deprecates. These already link to their associated constant equivalents. - `MAX` - `REPLACEMENT_CHARACTER` - `UNICODE_VERSION` two unstable constants that this PR removes. The constants are already stablized as associated constants on `char`. - `MAX_LEN_UTF8` - `MAX_LEN_UTF16` Four stable functions that this PR deprecates. These already link to their method equivalents. - `fn decode_utf16` - `fn from_digit` - `fn from_u32` - `fn from_u32_unchecked⚠` discussion at [#t-libs > should &rust-lang#96;std::char::{MIN, MAX}&rust-lang#96; be deprecated?](https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/should.20.60std.3A.3Achar.3A.3A.7BMIN.2C.20MAX.7D.60.20be.20deprecated.3F/with/579444750). r? libs-api

…ark-Simulacrum libtest: use binary search for --exact test filtering When `--exact` is passed in, use binary search for O(f log n) lookups instead of an O(n) linear scan, under the assumption that f << n (which is true for the most relevant cases). This is important for Miri, where the interpreted execution makes the linear scan very expensive. I measured this against a repo with 1000 empty tests, running `cargo +stage1 miri nextest run test_00` (100 tests) under hyperfine: * Before (linear scan): 49.7s ± 0.6s * After (binary search): 41.9s ± 0.2s (-15.7%) I also tried a few other variations (particularly swapping matching tests to the front of the list + truncating the list), but the index + swap_remove approach proved to be the fastest. Questions: - [ ] To be conservative, I've assumed that test_main can potentially receive an unsorted list of tests. Is this assumption correct?

jhpratt · 2026-04-19T03:56:43Z

@bors r+ rollup=never p=5

rust-bors · 2026-04-19T03:56:51Z

📌 Commit 4cb516d has been approved by jhpratt

It is now in the queue for this repository.

Rollup of 9 pull requests Successful merges: - #155370 (Add regression test for dead code elimination with drop + panic) - #154823 (Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser) - #154972 (Implement `core::arch::return_address` and tests) - #155294 (Add test for coalescing of diagnostic attribute duplicates) - #155352 (triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"`) - #155431 (Add temporary scope to assert_matches) - #152995 (ACP Implementation of PermissionsExt for Windows ) - #153873 (deprecate `std::char` constants and functions) - #154865 (libtest: use binary search for --exact test filtering)

rust-log-analyzer · 2026-04-19T08:13:29Z

The job test-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test library/core/src/time.rs - time::Duration::from_weeks (line 354) ... ok

failures:

---- library/core/src/arch.rs - arch::return_address (line 96) stdout ----
error: <unknown>:0:0: in function _RNvNvCs9KQx7FyHtNq_8rust_out4main43__doctest_main_library_core_src_arch_rs_96_0 void (): Non-Emscripten WebAssembly hasn't implemented __builtin_return_address
       

error: aborting due to 1 previous error

Couldn't compile the test.

rust-bors · 2026-04-19T08:14:03Z

💔 Test for 5a4e266 failed: CI. Failed job:

auto - test-various (web logs, enhanced plaintext logs)

rust-bors · 2026-04-19T08:14:59Z

PR #154972, which is a member of this rollup, was unapproved.

folkertdev and others added 21 commits March 15, 2026 11:18

deprecate std::char constants and functions

ee9b61c

similar to how constants in those modules for numeric types have been deprecated

Implemented PermissionsExt ACP on Windows, which provides functions/u…

782a214

…tilities to observe, set, and create a Permissions struct with certain file attributes

Add a bunch of unit tests for the in-house parser

57de72c

Move spdx.rs to spdx/mod.rs

1bdbde5

Add test for coalescing of diagnostic attribute duplicates

1d61770

Add temporary scope to assert_matches

e0ef87f

Addresses rust-lang#154406 in part. assert_eq will be done in a separate PR.

Apply review feedback

3a0c0e9

Rollup merge of rust-lang#154972 - chorman0773:return_address, r=Mark…

e7705cf

…-Simulacrum Implement `core::arch::return_address` and tests Tracking issue: rust-lang#154966 Implements libs-team#768

Rollup merge of rust-lang#155431 - Voultapher:add-tmp-scope-to-assert…

9f6b3c5

…-matches, r=Amanieu Add temporary scope to assert_matches Addresses rust-lang#154406 in part. `assert_eq` will be done in a separate PR.

rust-bors bot added the rollup A PR which is a rollup label Apr 19, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2026

jhpratt mentioned this pull request Apr 19, 2026

Implement core::arch::return_address and tests #154972

Open

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2026

jhpratt closed this Apr 19, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 19, 2026

jhpratt deleted the rollup-tMDKAQS branch April 19, 2026 08:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests#155506

Rollup of 9 pull requests#155506
jhpratt wants to merge 21 commits intorust-lang:mainfrom
jhpratt:rollup-tMDKAQS

jhpratt commented Apr 19, 2026

Uh oh!

jhpratt commented Apr 19, 2026

Uh oh!

rust-bors bot commented Apr 19, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Apr 19, 2026

Uh oh!

rust-bors bot commented Apr 19, 2026

Uh oh!

rust-bors bot commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

jhpratt commented Apr 19, 2026

Uh oh!

jhpratt commented Apr 19, 2026

Uh oh!

rust-bors bot commented Apr 19, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Apr 19, 2026

Uh oh!

rust-bors bot commented Apr 19, 2026

Uh oh!

rust-bors bot commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants