triagebot.toml: Sync assign.owners with autolabel."T-compiler"#155352
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 19, 2026
Merged
triagebot.toml: Sync assign.owners with autolabel."T-compiler"#155352rust-bors[bot] merged 1 commit intorust-lang:mainfrom
assign.owners with autolabel."T-compiler"#155352rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
In `autolabel."T-compiler"`, several `./tests/*` dirs are listed. But many of them are missing from `assign.owners`. Add them all to `assign.owners` so reviewers are picked from the compiler group, and not from the small `assign.adhoc_groups.fallback` group.
Collaborator
|
|
rustbot
added
A-meta
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 16, 2026
tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs We don't consider it a bug that users can't break on initialization of some non-zero sized types (see rust-lang#153941 and linked discussions), so it does not make sense to consider it a bug that users can't break on initialization of some zero-sized types. Closes rust-lang#97083 r? compiler (see rust-lang#155352)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 16, 2026
tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs We don't consider it a bug that users can't break on initialization of some non-zero sized types (see rust-lang#153941 and linked discussions), so it does not make sense to consider it a bug that users can't break on initialization of some zero-sized types. Closes rust-lang#97083 r? compiler (see rust-lang#155352)
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 16, 2026
tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs We don't consider it a bug that users can't break on initialization of some non-zero sized types (see rust-lang#153941 and linked discussions), so it does not make sense to consider it a bug that users can't break on initialization of some zero-sized types. Closes rust-lang#97083 r? compiler (see rust-lang#155352)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 17, 2026
tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs We don't consider it a bug that users can't break on initialization of some non-zero sized types (see rust-lang#153941 and linked discussions), so it does not make sense to consider it a bug that users can't break on initialization of some zero-sized types. Closes rust-lang#97083 r? compiler (see rust-lang#155352)
rust-timer
added a commit
that referenced
this pull request
Apr 17, 2026
Rollup merge of #155377 - Enselic:stepping-zsts, r=petrochenkov tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs We don't consider it a bug that users can't break on initialization of some non-zero sized types (see #153941 and linked discussions), so it does not make sense to consider it a bug that users can't break on initialization of some zero-sized types. Closes #97083 r? compiler (see #155352)
Member
|
I could see a couple of these using more specific groups (e.g., maybe mir-opt-only test PRs should include experts in that area) but I think this seems pretty reasonable. I wonder if we should blanket @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 19, 2026
triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"` In `autolabel."T-compiler"`, several `./tests/*` dirs are listed. But many of them are missing from `assign.owners`. Add them all to `assign.owners` so reviewers are picked from the compiler group, and not from the small `assign.adhoc_groups.fallback` group. Discovered in rust-lang#153941 (comment). CC fallback group @Mark-Simulacrum @jieyouxu who can maybe confirm that the old setup was not intentional? (Edit: I hope it was not intentional, because in that case I should have reached out to you personally beforehand.)
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2026
Rollup of 8 pull requests Successful merges: - #155370 (Add regression test for dead code elimination with drop + panic) - #154823 (Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser) - #155352 (triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"`) - #155431 (Add temporary scope to assert_matches) - #152995 (ACP Implementation of PermissionsExt for Windows ) - #153873 (deprecate `std::char` constants and functions) - #154654 (Move `std::io::ErrorKind` to `core::io`) - #154865 (libtest: use binary search for --exact test filtering)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 19, 2026
triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"` In `autolabel."T-compiler"`, several `./tests/*` dirs are listed. But many of them are missing from `assign.owners`. Add them all to `assign.owners` so reviewers are picked from the compiler group, and not from the small `assign.adhoc_groups.fallback` group. Discovered in rust-lang#153941 (comment). CC fallback group @Mark-Simulacrum @jieyouxu who can maybe confirm that the old setup was not intentional? (Edit: I hope it was not intentional, because in that case I should have reached out to you personally beforehand.)
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2026
Rollup of 9 pull requests Successful merges: - #155370 (Add regression test for dead code elimination with drop + panic) - #154823 (Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser) - #154972 (Implement `core::arch::return_address` and tests) - #155294 (Add test for coalescing of diagnostic attribute duplicates) - #155352 (triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"`) - #155431 (Add temporary scope to assert_matches) - #152995 (ACP Implementation of PermissionsExt for Windows ) - #153873 (deprecate `std::char` constants and functions) - #154865 (libtest: use binary search for --exact test filtering)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 19, 2026
triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"` In `autolabel."T-compiler"`, several `./tests/*` dirs are listed. But many of them are missing from `assign.owners`. Add them all to `assign.owners` so reviewers are picked from the compiler group, and not from the small `assign.adhoc_groups.fallback` group. Discovered in rust-lang#153941 (comment). CC fallback group @Mark-Simulacrum @jieyouxu who can maybe confirm that the old setup was not intentional? (Edit: I hope it was not intentional, because in that case I should have reached out to you personally beforehand.)
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2026
Rollup of 10 pull requests Successful merges: - #155370 (Add regression test for dead code elimination with drop + panic) - #154823 (Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser) - #155294 (Add test for coalescing of diagnostic attribute duplicates) - #155352 (triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"`) - #155431 (Add temporary scope to assert_matches) - #152995 (ACP Implementation of PermissionsExt for Windows ) - #153873 (deprecate `std::char` constants and functions) - #154865 (libtest: use binary search for --exact test filtering) - #154979 (add #[must_use] macros for floats) - #155504 (Remove `AttributeLintKind` variants - part 2)
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2026
…uwer Rollup of 12 pull requests Successful merges: - #155370 (Add regression test for dead code elimination with drop + panic) - #154823 (Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser) - #155294 (Add test for coalescing of diagnostic attribute duplicates) - #155352 (triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"`) - #155431 (Add temporary scope to assert_matches) - #153873 (deprecate `std::char` constants and functions) - #154865 (libtest: use binary search for --exact test filtering) - #154979 (add #[must_use] macros for floats) - #155486 (c-variadic: add roundtrip test) - #155504 (Remove `AttributeLintKind` variants - part 2) - #155510 (Update Tidy python executable path) - #155514 (codegen-options docs: remove -Csoft-float)
rust-timer
added a commit
that referenced
this pull request
Apr 19, 2026
Rollup merge of #155352 - Enselic:label-sync, r=Mark-Simulacrum triagebot.toml: Sync `assign.owners` with `autolabel."T-compiler"` In `autolabel."T-compiler"`, several `./tests/*` dirs are listed. But many of them are missing from `assign.owners`. Add them all to `assign.owners` so reviewers are picked from the compiler group, and not from the small `assign.adhoc_groups.fallback` group. Discovered in #153941 (comment). CC fallback group @Mark-Simulacrum @jieyouxu who can maybe confirm that the old setup was not intentional? (Edit: I hope it was not intentional, because in that case I should have reached out to you personally beforehand.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
autolabel."T-compiler", several./tests/*dirs are listed.But many of them are missing from
assign.owners. Add them all toassign.ownersso reviewers are picked from the compiler group, and not from the smallassign.adhoc_groups.fallbackgroup.Discovered in #153941 (comment).
CC fallback group @Mark-Simulacrum @jieyouxu who can maybe confirm that the old setup was not intentional? (Edit: I hope it was not intentional, because in that case I should have reached out to you personally beforehand.)