Skip to content

fix: import trait if needed for unqualify_method_call assist#15780

Merged
bors merged 2 commits into
rust-lang:masterfrom
Young-Flash:auto_import
Oct 23, 2023
Merged

fix: import trait if needed for unqualify_method_call assist#15780
bors merged 2 commits into
rust-lang:masterfrom
Young-Flash:auto_import

Conversation

@Young-Flash

@Young-Flash Young-Flash commented Oct 18, 2023

Copy link
Copy Markdown
Member

before:

before

after:

after

follow up #13825

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2023
Comment thread crates/ide-assists/src/handlers/unqualify_method_call.rs Outdated
Comment thread crates/ide-assists/src/handlers/unqualify_method_call.rs Outdated
@Young-Flash

Copy link
Copy Markdown
Member Author

ready for review

cc @lnicola

Comment thread crates/ide-assists/src/handlers/unqualify_method_call.rs Outdated
@lnicola

lnicola commented Oct 23, 2023

Copy link
Copy Markdown
Member

Thanks!

@bors r+

@bors

bors commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

📌 Commit 45ee88f has been approved by lnicola

It is now in the queue for this repository.

@lnicola lnicola changed the title fix: auto import trait if needed for unqualify_method_call assist fix: import trait if needed for unqualify_method_call assist Oct 23, 2023
@bors

bors commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit 45ee88f with merge 2f6961a...

@bors

bors commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 2f6961a to master...

@bors
bors merged commit 2f6961a into rust-lang:master Oct 23, 2023
@Young-Flash
Young-Flash deleted the auto_import branch October 24, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants