Skip to content

feat: Add unqualify_method_call assist#13825

Merged
bors merged 2 commits into
rust-lang:masterfrom
WaffleLapkin:ufcs_to_method_call_and_back
Jan 9, 2023
Merged

feat: Add unqualify_method_call assist#13825
bors merged 2 commits into
rust-lang:masterfrom
WaffleLapkin:ufcs_to_method_call_and_back

Conversation

@WaffleLapkin

@WaffleLapkin WaffleLapkin commented Dec 22, 2022

Copy link
Copy Markdown
Member

...which is the inverse of qualify_method_call assist.

Peek 2022-12-22 22-47

Optional future work:

  • import the trait if needed
  • remove excess references when auto-ref is possible

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2022
@flodiebold

flodiebold commented Dec 22, 2022

Copy link
Copy Markdown
Member

I think the acronym "UFCS" is a bit unfriendly, maybe something like "Convert to .add method call"? (Also btw, why is "Qualify method call" under "Inline"?)

@Veykril

Veykril commented Jan 2, 2023

Copy link
Copy Markdown
Member

+1 to UFCS being a bad choice for the user visible text

Also btw, why is "Qualify method call" under "Inline"?

Probably because both target the same range and our assists are ordered alphabetically by default (with a few exceptions, where this would probably be a good choice to do so as well)

@flodiebold

flodiebold commented Jan 2, 2023

Copy link
Copy Markdown
Member

Probably because both target the same range and our assists are ordered alphabetically by default (with a few exceptions, where this would probably be a good choice to do so as well)

I didn't mean the order, rather that it's under the Inline... group (whereas the new assist is Rewrite...) 😅

@rust-cloud-vms
rust-cloud-vms Bot force-pushed the ufcs_to_method_call_and_back branch from 59889c1 to 44c84a8 Compare January 9, 2023 13:50
@WaffleLapkin WaffleLapkin changed the title feat: Add convert_ufcs_to_method assist feat: Add unqualify_method_call assist Jan 9, 2023
@Veykril

Veykril commented Jan 9, 2023

Copy link
Copy Markdown
Member

@bors delegate+

@bors

bors commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

✌️ @WaffleLapkin can now approve this pull request

@rust-cloud-vms
rust-cloud-vms Bot force-pushed the ufcs_to_method_call_and_back branch from a48d5f5 to c782353 Compare January 9, 2023 14:24
@WaffleLapkin

WaffleLapkin commented Jan 9, 2023

Copy link
Copy Markdown
Member Author

@bors r=Veykril

@bors

bors commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

📌 Commit c782353 has been approved by Veykril

It is now in the queue for this repository.

@WaffleLapkin WaffleLapkin mentioned this pull request Jan 9, 2023
Merged
@bors

bors commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit c782353 with merge d33fa38...

@bors

bors commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing d33fa38 to master...

@bors
bors merged commit d33fa38 into rust-lang:master Jan 9, 2023
bors added a commit that referenced this pull request Jan 9, 2023
@bors
Auto merge of #13914 - WaffleLapkin:qualify_method_call_rewrite, r=ln…
f920b03 
…icola

minor: Make `qualify_method_call` `RefactorRewrite`

See #13825 (comment)
@DropDemBits DropDemBits mentioned this pull request Jan 17, 2023
Closed
@Young-Flash Young-Flash mentioned this pull request Oct 18, 2023
Merged
bors added a commit that referenced this pull request Oct 23, 2023
@bors
Auto merge of #15780 - Young-Flash:auto_import, r=lnicola
2f6961a 
fix: import trait if needed for `unqualify_method_call` assist

before:

![before](https://github.com/rust-lang/rust-analyzer/assets/71162630/66fda67d-afcb-453f-91a9-7e85993c3d2a)

after:

![after](https://github.com/rust-lang/rust-analyzer/assets/71162630/72ffbda4-1615-4413-836e-480eb52e9728)

follow up #13825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WaffleLapkin @flodiebold @Veykril @bors @rustbot