Skip to content

fix: remove deprecated BillingId and OrgId from checkout tests#1513

Merged
rohilsurana merged 1 commit intomainfrom
fix/remove-billing-id-from-checkout-tests
Apr 7, 2026
Merged

fix: remove deprecated BillingId and OrgId from checkout tests#1513
rohilsurana merged 1 commit intomainfrom
fix/remove-billing-id-from-checkout-tests

Conversation

@rohilsurana
Copy link
Copy Markdown
Member

Summary

  • Remove BillingId field from CreateCheckoutRequest and ListCheckoutsRequest test cases as it was removed from the proto definition
  • Remove OrgId field from GetCheckoutRequest test cases as it was also removed from the proto
  • Remove test cases that validated OrgId emptiness in GetCheckout since the field no longer exists

Test plan

  • Unit tests pass (go vet, go build)
  • E2E tests pass (go test ./test/e2e/...)

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Apr 7, 2026 6:15am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated billing checkout test cases, removing field validation requirements from request payloads while maintaining coverage of core functionality and error handling.

Walkthrough

A test file for billing checkout handlers is updated to remove BillingId field from create and list checkout request test cases, and remove OrgId field from get checkout test cases. Test structure and assertion logic remain unchanged.

Changes

Cohort / File(s) Summary
Billing Checkout Tests
internal/api/v1beta1connect/billing_checkout_test.go
Removes BillingId from CreateCheckoutRequest and ListCheckoutsRequest test cases; removes OrgId from GetCheckoutRequest test cases and eliminates the test scenario validating errors when OrgId is empty. Handler assertions and response validation unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • rsbh
  • whoAbhishekSah

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohilsurana rohilsurana enabled auto-merge (squash) April 7, 2026 06:16
@rohilsurana rohilsurana merged commit cba9d2d into main Apr 7, 2026
7 of 8 checks passed
@rohilsurana rohilsurana deleted the fix/remove-billing-id-from-checkout-tests branch April 7, 2026 06:17
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24067229720

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 41.209%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 36235
Covered Lines: 14932
Line Coverage: 41.21%
Coverage Strength: 11.91 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants