Skip to content

fix: update GetBillingAccount rpc across clients#1505

Merged
rohanchkrabrty merged 2 commits intomainfrom
update-get-billing-account
Apr 2, 2026
Merged

fix: update GetBillingAccount rpc across clients#1505
rohanchkrabrty merged 2 commits intomainfrom
update-get-billing-account

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

@rohanchkrabrty rohanchkrabrty commented Apr 2, 2026

Summary

  • update the GetBillingAccount RPC contract and regenerate protobuf outputs to keep server/client APIs in sync
  • align admin app billing account usage with the updated RPC shape to avoid request/response mismatches
  • refresh workspace lockfiles and package metadata impacted by the protobuf/client update

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Apr 2, 2026 11:25am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2c990577-5dc7-4ace-aec7-fd861faafe74

📥 Commits

Reviewing files that changed from the base of the PR and between 40dc6a5 and 54cabc9.

📒 Files selected for processing (1)
  • test/e2e/regression/billing_test.go
💤 Files with no reviewable changes (1)
  • test/e2e/regression/billing_test.go

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Updated internal dependencies and tooling to newer releases for improved compatibility.
  • Bug Fixes

    • Fixed billing account retrieval to send the correct request shape across UI and tests, ensuring billing details are fetched reliably.

Walkthrough

Update Proton commit/version across build and package configs, add a new SDK dependency, refactor a billing-account RPC request to use a schema creator, and remove OrgId from an e2e test's GetBillingAccount request.

Changes

Cohort / File(s) Summary
Proton & deps
Makefile, web/apps/admin/package.json, web/sdk/package.json
Bumped PROTON_COMMIT in Makefile and updated @raystack/proton dependency references; added @base-ui/react to web/sdk dependencies.
Billing account query
web/sdk/admin/views/organizations/details/index.tsx
Changed RPC input construction to create(GetBillingAccountRequestSchema, {...}) and adjusted imports/arguments accordingly.
E2E test adjustment
test/e2e/regression/billing_test.go
Removed OrgId from GetBillingAccount requests in two subtests, leaving only Id and Expand.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • rohilsurana
  • paanSinghCoder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 965a9708-f82c-4104-88d4-3ef4f0f6e1b2

📥 Commits

Reviewing files that changed from the base of the PR and between 35b31d0 and 40dc6a5.

⛔ Files ignored due to path filters (2)
  • proto/v1beta1/frontier.pb.go is excluded by !**/*.pb.go, !proto/**
  • web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • Makefile
  • web/apps/admin/package.json
  • web/sdk/admin/views/organizations/details/index.tsx
  • web/sdk/package.json

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 2, 2026

Pull Request Test Coverage Report for Build 23898081466

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.249%

Totals Coverage Status
Change from base Build 23892727101: 0.0%
Covered Lines: 14910
Relevant Lines: 36146

💛 - Coveralls

@rohanchkrabrty rohanchkrabrty enabled auto-merge (squash) April 2, 2026 11:35
@rohanchkrabrty rohanchkrabrty merged commit a07aaa4 into main Apr 2, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the update-get-billing-account branch April 2, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants