Skip to content

feat: security page revamp#1493

Merged
rohanchkrabrty merged 12 commits intomainfrom
feat-security-revamp
Apr 6, 2026
Merged

feat: security page revamp#1493
rohanchkrabrty merged 12 commits intomainfrom
feat-security-revamp

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Migrate SDK to @raystack/apsara-v1 and update all settings pages (general, profile, preferences, members, sessions, security) under views-new/
  • Add imperative dialog/menu handle pattern (Dialog.createHandle, AlertDialog.createHandle, Menu.createHandle) for controlled component state management
  • Implement new reusable components: ViewContainer, ViewHeader, ImageUpload
  • Add members page with invite, remove, and role update flows using DataTable and connect-rpc mutations
  • Add security page with domain add, verify (DNS TXT record), and delete flows
  • Wire up client-demo app with settings routes for all new views

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Apr 6, 2026 5:21am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added a new Security settings section to manage allowed email domains for your organization
    • Added ability to add new domains, verify them with a verification token, and delete existing domains
    • Domains now display verification status indicators

Walkthrough

Added a new Security feature to the settings area, including a security sub-route, navigation entry, and SecurityView page component. Implemented domain management dialogs for adding, verifying, and deleting organization email domains. Enhanced PreferencesView to support optional children. Updated SDK exports to expose SecurityView and related components.

Changes

Cohort / File(s) Summary
Routing & Navigation
web/apps/client-demo/src/Router.tsx, web/apps/client-demo/src/pages/Settings.tsx
Added security sub-route under settings parent route and corresponding navigation item with active state tracking and test ID.
Security Page Component
web/apps/client-demo/src/pages/settings/Security.tsx
Created wrapper component that renders SecurityView from the SDK.
Security Feature Core
web/sdk/react/views-new/security/security-view.tsx, web/sdk/react/views-new/security/security-view.module.css
Implemented main SecurityView component managing allowed email domains with domain listing, permission checks, and dialog interactions. Added CSS module with section, header, domain cell, and verified state styling.
Domain Management Dialogs
web/sdk/react/views-new/security/components/add-domain-dialog.tsx, web/sdk/react/views-new/security/components/delete-domain-dialog.tsx, web/sdk/react/views-new/security/components/verify-domain-dialog.tsx
Created three dialog components for domain lifecycle: adding new domains with validation, deleting with confirmation and domain-name matching, and verifying with token display and mutation handling. Each includes form handling, query invalidation, and error/success toast notifications.
SDK Exports
web/sdk/react/index.ts, web/sdk/react/views-new/security/index.ts
Added re-exports of SecurityView and SecurityViewProps to make components available through the SDK public API.
PreferencesView Enhancement
web/sdk/react/views-new/preferences/preferences-view.tsx
Updated component signature to accept optional children prop and render children within the main layout. Removed unused Skeleton import and adjusted JSX formatting.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

Suggested reviewers

  • rohilsurana
  • rsbh
  • paanSinghCoder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the title feat: revamp SDK settings pages with apsara v1 feat: security page revamp Mar 31, 2026
@rohanchkrabrty rohanchkrabrty added the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Mar 31, 2026
@rohanchkrabrty rohanchkrabrty changed the base branch from main to feat-members-revamp March 31, 2026 10:16
@rohanchkrabrty rohanchkrabrty removed the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Apr 6, 2026
Base automatically changed from feat-members-revamp to main April 6, 2026 05:17
@rohanchkrabrty rohanchkrabrty enabled auto-merge (squash) April 6, 2026 05:21
@rohanchkrabrty rohanchkrabrty merged commit 072202e into main Apr 6, 2026
7 of 8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the feat-security-revamp branch April 6, 2026 05:25
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 24019846023

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.238%

Totals Coverage Status
Change from base Build 24019785933: 0.0%
Covered Lines: 14931
Relevant Lines: 36207

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants